* [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler
@ 2013-10-02 11:08 Taras Kondratiuk
2013-10-02 16:43 ` [LNG] " Kim Phillips
2013-10-03 23:00 ` [PATCH v2] " Taras Kondratiuk
0 siblings, 2 replies; 4+ messages in thread
From: Taras Kondratiuk @ 2013-10-02 11:08 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones
Cc: linux-omap, linux-kernel, linaro-networking, Danke Xie, Taras Kondratiuk
From: Danke Xie <d.xie@sta.samsung.com>
The current TWL 6030 IRQ handler assumes little endianness.
This change makes it endian-neutral.
Signed-off-by: Danke Xie <d.xie@sta.samsung.com>
Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
---
drivers/mfd/twl6030-irq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c
index 517eda8..1941dc6 100644
--- a/drivers/mfd/twl6030-irq.c
+++ b/drivers/mfd/twl6030-irq.c
@@ -178,6 +178,7 @@ static irqreturn_t twl6030_irq_thread(int irq, void *data)
u8 bytes[4];
u32 int_sts;
} sts;
+ u32 int_sts; /* sts.int_sts converted to CPU endianness */
struct twl6030_irq *pdata = data;
/* read INT_STS_A, B and C in one shot using a burst read */
@@ -196,8 +197,9 @@ static irqreturn_t twl6030_irq_thread(int irq, void *data)
if (sts.bytes[2] & 0x10)
sts.bytes[2] |= 0x08;
- for (i = 0; sts.int_sts; sts.int_sts >>= 1, i++)
- if (sts.int_sts & 0x1) {
+ int_sts = le32_to_cpu(sts.int_sts);
+ for (i = 0; int_sts; int_sts >>= 1, i++)
+ if (int_sts & 0x1) {
int module_irq =
irq_find_mapping(pdata->irq_domain,
pdata->irq_mapping_tbl[i]);
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LNG] [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler
2013-10-02 11:08 [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler Taras Kondratiuk
@ 2013-10-02 16:43 ` Kim Phillips
2013-10-02 21:08 ` Taras Kondratiuk
2013-10-03 23:00 ` [PATCH v2] " Taras Kondratiuk
1 sibling, 1 reply; 4+ messages in thread
From: Kim Phillips @ 2013-10-02 16:43 UTC (permalink / raw)
To: taras.kondratiuk
Cc: sameo, lee.jones, linux-omap, linux-kernel, linaro-networking, d.xie
On Wed, 2 Oct 2013 14:08:44 +0300
Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote:
> From: Danke Xie <d.xie@sta.samsung.com>
>
> The current TWL 6030 IRQ handler assumes little endianness.
> This change makes it endian-neutral.
>
> Signed-off-by: Danke Xie <d.xie@sta.samsung.com>
> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
> ---
this patch causes a new sparse warning:
make C=2 CF="-D__CHECK_ENDIAN__" drivers/mfd/twl6030-irq.o
...
CHECK drivers/mfd/twl6030-irq.c
drivers/mfd/twl6030-irq.c:200:19: warning: cast to restricted __le32
does int_sts in the sts union need to be defined as __le32?
Thanks,
Kim
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LNG] [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler
2013-10-02 16:43 ` [LNG] " Kim Phillips
@ 2013-10-02 21:08 ` Taras Kondratiuk
0 siblings, 0 replies; 4+ messages in thread
From: Taras Kondratiuk @ 2013-10-02 21:08 UTC (permalink / raw)
To: Kim Phillips
Cc: sameo, lee.jones, linux-omap, linux-kernel, Linaro Networking, d.xie
On 2 October 2013 19:43, Kim Phillips <kim.phillips@linaro.org> wrote:
> On Wed, 2 Oct 2013 14:08:44 +0300
> Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote:
>
>> From: Danke Xie <d.xie@sta.samsung.com>
>>
>> The current TWL 6030 IRQ handler assumes little endianness.
>> This change makes it endian-neutral.
>>
>> Signed-off-by: Danke Xie <d.xie@sta.samsung.com>
>> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
>> ---
>
> this patch causes a new sparse warning:
>
> make C=2 CF="-D__CHECK_ENDIAN__" drivers/mfd/twl6030-irq.o
> ...
> CHECK drivers/mfd/twl6030-irq.c
> drivers/mfd/twl6030-irq.c:200:19: warning: cast to restricted __le32
>
> does int_sts in the sts union need to be defined as __le32?
You are right.
I will update the patch.
--
Regards,
Taras Kondratiuk
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] mfd: twl6030: Fix endianness problem in IRQ handler
2013-10-02 11:08 [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler Taras Kondratiuk
2013-10-02 16:43 ` [LNG] " Kim Phillips
@ 2013-10-03 23:00 ` Taras Kondratiuk
1 sibling, 0 replies; 4+ messages in thread
From: Taras Kondratiuk @ 2013-10-03 23:00 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones
Cc: linux-omap, linux-kernel, linaro-networking, Kim Phillips,
Danke Xie, Taras Kondratiuk
From: Danke Xie <d.xie@sta.samsung.com>
The current TWL 6030 IRQ handler assumes little endianness.
This change makes it endian-neutral.
Signed-off-by: Danke Xie <d.xie@sta.samsung.com>
Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
---
v2: fixed sparse warning
v1: https://patchwork.kernel.org/patch/2974331/
drivers/mfd/twl6030-irq.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c
index 517eda8..18a607e 100644
--- a/drivers/mfd/twl6030-irq.c
+++ b/drivers/mfd/twl6030-irq.c
@@ -176,8 +176,9 @@ static irqreturn_t twl6030_irq_thread(int irq, void *data)
int i, ret;
union {
u8 bytes[4];
- u32 int_sts;
+ __le32 int_sts;
} sts;
+ u32 int_sts; /* sts.int_sts converted to CPU endianness */
struct twl6030_irq *pdata = data;
/* read INT_STS_A, B and C in one shot using a burst read */
@@ -196,8 +197,9 @@ static irqreturn_t twl6030_irq_thread(int irq, void *data)
if (sts.bytes[2] & 0x10)
sts.bytes[2] |= 0x08;
- for (i = 0; sts.int_sts; sts.int_sts >>= 1, i++)
- if (sts.int_sts & 0x1) {
+ int_sts = le32_to_cpu(sts.int_sts);
+ for (i = 0; int_sts; int_sts >>= 1, i++)
+ if (int_sts & 0x1) {
int module_irq =
irq_find_mapping(pdata->irq_domain,
pdata->irq_mapping_tbl[i]);
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-03 23:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-02 11:08 [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler Taras Kondratiuk
2013-10-02 16:43 ` [LNG] " Kim Phillips
2013-10-02 21:08 ` Taras Kondratiuk
2013-10-03 23:00 ` [PATCH v2] " Taras Kondratiuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®