From: Mark Brown <broonie@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] regulator: wm8994: Remove redundant break
Date: Fri, 4 Oct 2013 11:47:02 +0100 [thread overview]
Message-ID: <20131004104702.GL27287@sirena.org.uk> (raw)
In-Reply-To: <1380880098-25188-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Fri, Oct 04, 2013 at 03:18:17PM +0530, Sachin Kamat wrote:
> default:
> return (selector * 100000) + 950000;
> }
> - break;
> default:
I'm not sure this is actually a clarity improvement. While the break is
redundant the return statements are all inside the nested switch so it's
not entirely obvious at a glance that all the paths were covered.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-10-04 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 9:48 Sachin Kamat
2013-10-04 9:48 ` [PATCH 2/2] regulator: gpio: " Sachin Kamat
2013-10-04 10:50 ` Mark Brown
2013-10-04 10:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004104702.GL27287@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®