* [PATCH 1/2] regulator: wm8994: Remove redundant break
@ 2013-10-04 9:48 Sachin Kamat
2013-10-04 9:48 ` [PATCH 2/2] regulator: gpio: " Sachin Kamat
2013-10-04 10:47 ` [PATCH 1/2] regulator: wm8994: " Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-10-04 9:48 UTC (permalink / raw)
To: linux-kernel; +Cc: broonie, patches, sachin.kamat
'break' after return has no effect. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/regulator/wm8994-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/wm8994-regulator.c b/drivers/regulator/wm8994-regulator.c
index 71c5911..ffc1b2f 100644
--- a/drivers/regulator/wm8994-regulator.c
+++ b/drivers/regulator/wm8994-regulator.c
@@ -63,7 +63,6 @@ static int wm8994_ldo2_list_voltage(struct regulator_dev *rdev,
default:
return (selector * 100000) + 950000;
}
- break;
default:
return -EINVAL;
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] regulator: gpio: Remove redundant break
2013-10-04 9:48 [PATCH 1/2] regulator: wm8994: Remove redundant break Sachin Kamat
@ 2013-10-04 9:48 ` Sachin Kamat
2013-10-04 10:50 ` Mark Brown
2013-10-04 10:47 ` [PATCH 1/2] regulator: wm8994: " Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2013-10-04 9:48 UTC (permalink / raw)
To: linux-kernel; +Cc: broonie, patches, sachin.kamat
'break' after goto has no effect. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/regulator/gpio-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 98a98ff..04406a9 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -283,7 +283,6 @@ static int gpio_regulator_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "No regulator type set\n");
ret = -EINVAL;
goto err_memgpio;
- break;
}
drvdata->nr_gpios = config->nr_gpios;
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] regulator: wm8994: Remove redundant break
2013-10-04 9:48 [PATCH 1/2] regulator: wm8994: Remove redundant break Sachin Kamat
2013-10-04 9:48 ` [PATCH 2/2] regulator: gpio: " Sachin Kamat
@ 2013-10-04 10:47 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-10-04 10:47 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, patches
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Fri, Oct 04, 2013 at 03:18:17PM +0530, Sachin Kamat wrote:
> default:
> return (selector * 100000) + 950000;
> }
> - break;
> default:
I'm not sure this is actually a clarity improvement. While the break is
redundant the return statements are all inside the nested switch so it's
not entirely obvious at a glance that all the paths were covered.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-04 10:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-04 9:48 [PATCH 1/2] regulator: wm8994: Remove redundant break Sachin Kamat
2013-10-04 9:48 ` [PATCH 2/2] regulator: gpio: " Sachin Kamat
2013-10-04 10:50 ` Mark Brown
2013-10-04 10:47 ` [PATCH 1/2] regulator: wm8994: " Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®