* [PATCH] regulator: ti-abb: Fix operator precedence typo
@ 2013-10-11 10:04 Nishanth Menon
2013-10-11 11:29 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Menon @ 2013-10-11 10:04 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: linux-kernel, Nishanth Menon
commit 40b1936e (regulator: Introduce TI Adaptive Body Bias(ABB) on-chip
LDO driver) missed a pair of brackets which cause the wrong vset data to be
picked up from efuse, resulting in bad VBB voltage values.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
drivers/regulator/ti-abb-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb-regulator.c
index 20c271d..b993ec5 100644
--- a/drivers/regulator/ti-abb-regulator.c
+++ b/drivers/regulator/ti-abb-regulator.c
@@ -615,7 +615,7 @@ static int ti_abb_init_table(struct device *dev, struct ti_abb *abb,
pname, *volt_table, vset_mask);
continue;
}
- info->vset = efuse_val & vset_mask >> __ffs(vset_mask);
+ info->vset = (efuse_val & vset_mask) >> __ffs(vset_mask);
dev_dbg(dev, "[%d]v=%d vset=%x\n", i, *volt_table, info->vset);
check_abb:
switch (info->opp_sel) {
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: ti-abb: Fix operator precedence typo
2013-10-11 10:04 [PATCH] regulator: ti-abb: Fix operator precedence typo Nishanth Menon
@ 2013-10-11 11:29 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-10-11 11:29 UTC (permalink / raw)
To: Nishanth Menon; +Cc: Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
On Fri, Oct 11, 2013 at 05:04:12AM -0500, Nishanth Menon wrote:
> commit 40b1936e (regulator: Introduce TI Adaptive Body Bias(ABB) on-chip
> LDO driver) missed a pair of brackets which cause the wrong vset data to be
> picked up from efuse, resulting in bad VBB voltage values.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-11 11:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-11 10:04 [PATCH] regulator: ti-abb: Fix operator precedence typo Nishanth Menon
2013-10-11 11:29 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®