From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>, cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH v2 03/12] cpuset: update cs->effective_{cpus,mems} when config changes
Date: Tue, 15 Oct 2013 11:18:51 -0400 [thread overview]
Message-ID: <20131015151851.GK3141@htj.dyndns.org> (raw)
In-Reply-To: <5257C9CC.3080806@huawei.com>
On Fri, Oct 11, 2013 at 05:50:04PM +0800, Li Zefan wrote:
> + cpuset_for_each_descendant_pre(cp, pos_css, cs) {
> + struct cpuset *parent = parent_cs(cp);
> + struct cpumask *new_cpus = trialcs->effective_cpus;
> +
> + cpumask_and(new_cpus, cp->cpus_allowed,
> + parent->effective_cpus);
So, @trial_cs is only passed in to use its ->effective_cpus as
temporary buffer? If allocating from inside the function isn't an
option, wouldn't it be better to pass in cpumask * instead of the
whole trial_cs and explicitly note that the argument is used as a temp
var?
...
> + cpuset_for_each_descendant_pre(cp, pos_css, cs) {
> + struct cpuset *parent = parent_cs(cp);
> + nodemask_t *new_mems = &trialcs->effective_mems;
> +
> + nodes_and(*new_mems, cp->mems_allowed,
> + parent->effective_mems);
Ditto.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-10-15 15:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 9:49 [PATCH v2 00/12] cpuset: separate configured masks and effective masks Li Zefan
2013-10-11 9:49 ` [PATCH v2 01/12] cpuset: add cs->effective_cpus and cs->effective_mems Li Zefan
2013-10-11 9:49 ` [PATCH v2 02/12] cpuset: update cpuset->effective_{cpus,mems} at hotplug Li Zefan
2013-10-11 9:50 ` [PATCH v2 03/12] cpuset: update cs->effective_{cpus,mems} when config changes Li Zefan
2013-10-15 15:18 ` Tejun Heo [this message]
2013-10-11 9:50 ` [PATCH v2 04/12] cpuset: inherit ancestor's masks if effective_{cpus,mems} becomes empty Li Zefan
2013-10-11 9:50 ` [PATCH v2 05/12] cpuset: use effective cpumask to build sched domains Li Zefan
2013-10-15 15:25 ` Tejun Heo
2013-10-11 9:50 ` [PATCH v2 06/12] cpuset: initialize top_cpuset's configured masks at mount Li Zefan
2013-10-11 9:51 ` [PATCH v2 07/12] cpuset: apply cs->effective_{cpus,mems} Li Zefan
2013-10-11 9:51 ` [PATCH v2 08/12] cpuset: make cs->{cpus,mems}_allowed as user-configured masks Li Zefan
2013-10-11 9:51 ` [PATCH v2 09/12] cpuset: refactor cpuset_hotplug_update_tasks() Li Zefan
2013-10-11 9:51 ` [PATCH v2 10/12] cpuset: enable onlined cpu/node in effective masks Li Zefan
2013-10-11 9:51 ` [PATCH v2 11/12] cpuset: allow writing offlined masks to cpuset.cpus/mems Li Zefan
2013-10-15 15:36 ` Tejun Heo
2013-10-11 9:52 ` [PATCH v2 12/12] cpuset: export effective masks to userspace Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015151851.GK3141@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®