* [PATCH] staging: drm/imx: fix return value check in imx_drm_init()
@ 2013-10-25 9:07 Wei Yongjun
2013-10-28 7:57 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-10-25 9:07 UTC (permalink / raw)
To: gregkh, s.hauer, airlied, daniel.vetter, p.zabel
Cc: yongjun_wei, devel, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/staging/imx-drm/imx-drm-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
index a2e52a0..835a1b1 100644
--- a/drivers/staging/imx-drm/imx-drm-core.c
+++ b/drivers/staging/imx-drm/imx-drm-core.c
@@ -837,8 +837,8 @@ static int __init imx_drm_init(void)
INIT_LIST_HEAD(&imx_drm_device->encoder_list);
imx_drm_pdev = platform_device_register_simple("imx-drm", -1, NULL, 0);
- if (!imx_drm_pdev) {
- ret = -EINVAL;
+ if (IS_ERR(imx_drm_pdev)) {
+ ret = PTR_ERR(imx_drm_pdev);
goto err_pdev;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: drm/imx: fix return value check in imx_drm_init()
2013-10-25 9:07 [PATCH] staging: drm/imx: fix return value check in imx_drm_init() Wei Yongjun
@ 2013-10-28 7:57 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-10-28 7:57 UTC (permalink / raw)
To: Wei Yongjun
Cc: gregkh, airlied, daniel.vetter, p.zabel, yongjun_wei, devel,
linux-kernel
On Fri, Oct 25, 2013 at 05:07:18PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function platform_device_register_simple() returns
> ERR_PTR() and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/staging/imx-drm/imx-drm-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
> index a2e52a0..835a1b1 100644
> --- a/drivers/staging/imx-drm/imx-drm-core.c
> +++ b/drivers/staging/imx-drm/imx-drm-core.c
> @@ -837,8 +837,8 @@ static int __init imx_drm_init(void)
> INIT_LIST_HEAD(&imx_drm_device->encoder_list);
>
> imx_drm_pdev = platform_device_register_simple("imx-drm", -1, NULL, 0);
> - if (!imx_drm_pdev) {
> - ret = -EINVAL;
> + if (IS_ERR(imx_drm_pdev)) {
> + ret = PTR_ERR(imx_drm_pdev);
> goto err_pdev;
> }
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-28 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-25 9:07 [PATCH] staging: drm/imx: fix return value check in imx_drm_init() Wei Yongjun
2013-10-28 7:57 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®