From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net 2/3] r8152: modify the tx flow
Date: Tue, 29 Oct 2013 17:49:36 -0400 (EDT) [thread overview]
Message-ID: <20131029.174936.13317032766742363.davem@davemloft.net> (raw)
In-Reply-To: <1383033377-1178-3-git-send-email-hayeswang@realtek.com>
From: Hayes Wang <hayeswang@realtek.com>
Date: Tue, 29 Oct 2013 15:56:16 +0800
> Support stopping and waking tx queue. The maximum tx queue length
> is 60.
What is so special about the number 60? It seems arbitrary, and if
it isn't arbitrary you haven't described why this value was choosen.
I've asked you politely last time around to significantly improve
the quality of your commit messages, and you haven't done this at
all.
I'm not applying any of these patches until your commit messages
properly describe your changes completely.
next prev parent reply other threads:[~2013-10-29 21:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 7:56 [PATCH net 0/3] r8152 bug fixes Hayes Wang
2013-10-29 7:56 ` [PATCH net 1/3] r8152: fix tx/rx memory overflow Hayes Wang
2013-10-29 7:56 ` [PATCH net 2/3] r8152: modify the tx flow Hayes Wang
2013-10-29 21:49 ` David Miller [this message]
2013-10-30 3:03 ` hayeswang
2013-10-30 3:08 ` David Miller
2013-10-29 7:56 ` [PATCH net 3/3] r8152: fix incorrect type in assignment Hayes Wang
2013-10-30 7:13 ` [PATCH net v2 0/3] r8152 bug fixes Hayes Wang
2013-10-30 7:13 ` [PATCH net v2 1/3] r8152: fix tx/rx memory overflow Hayes Wang
2013-10-30 7:13 ` [PATCH net v2 2/3] r8152: modify the tx flow Hayes Wang
2013-10-30 21:04 ` David Miller
2013-10-31 5:52 ` hayeswang
2013-11-04 20:53 ` David Miller
2013-11-05 12:46 ` hayeswang
2013-10-30 7:13 ` [PATCH net v2 3/3] r8152: fix incorrect type in assignment Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029.174936.13317032766742363.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®