From: hayeswang <hayeswang@realtek.com>
To: "'David Miller'" <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, "'nic_swsd'" <nic_swsd@realtek.com>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: RE: [PATCH net v2 2/3] r8152: modify the tx flow
Date: Thu, 31 Oct 2013 13:52:38 +0800 [thread overview]
Message-ID: <3FC2D94481C34A40A55B033CB9CFA9FB@realtek.com.tw> (raw)
In-Reply-To: <20131030.170441.2031802071448773661.davem@davemloft.net>
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, October 31, 2013 5:05 AM
>
> From: Hayes Wang <hayeswang@realtek.com>
> Date: Wed, 30 Oct 2013 15:13:39 +0800
[...]
> Basically, your driver will now queue up to 1,000 packets onto
> this tx_queue list, because that is what tx_queue_len will be
> for alloc_etherdev() allocated network devices.
>
> In my previous reply to you about this patch, I asked you to
> quantify and study the effects of using a limit of 60. I said
> that 60 might be too large.
>
> You've responded by removing the limit completely, which is exactly
> the opposite of what I've asked you to do. Why did you do this?
Excuse me. My question is that the original code doesn't stop the tx queue
either, so I don't understand why it is necessary for this patch.
I don't say I wouldn't find the suitable value for the tx queue length.
I feel I need some time to think how to find the reasonable value. And
I don't hope it influences the submission of the other patches, so I
remove it first. Or, may I submit the other two patches first?
next prev parent reply other threads:[~2013-10-31 5:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 7:56 [PATCH net 0/3] r8152 bug fixes Hayes Wang
2013-10-29 7:56 ` [PATCH net 1/3] r8152: fix tx/rx memory overflow Hayes Wang
2013-10-29 7:56 ` [PATCH net 2/3] r8152: modify the tx flow Hayes Wang
2013-10-29 21:49 ` David Miller
2013-10-30 3:03 ` hayeswang
2013-10-30 3:08 ` David Miller
2013-10-29 7:56 ` [PATCH net 3/3] r8152: fix incorrect type in assignment Hayes Wang
2013-10-30 7:13 ` [PATCH net v2 0/3] r8152 bug fixes Hayes Wang
2013-10-30 7:13 ` [PATCH net v2 1/3] r8152: fix tx/rx memory overflow Hayes Wang
2013-10-30 7:13 ` [PATCH net v2 2/3] r8152: modify the tx flow Hayes Wang
2013-10-30 21:04 ` David Miller
2013-10-31 5:52 ` hayeswang [this message]
2013-11-04 20:53 ` David Miller
2013-11-05 12:46 ` hayeswang
2013-10-30 7:13 ` [PATCH net v2 3/3] r8152: fix incorrect type in assignment Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FC2D94481C34A40A55B033CB9CFA9FB@realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®