mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH TRIVIAL] sched: Fix comments in struct root_domain
Date: Fri, 15 Nov 2013 11:07:15 +0100	[thread overview]
Message-ID: <20131115100715.GE2965@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1384505917-18366-1-git-send-email-kamalesh@linux.vnet.ibm.com>

On Fri, Nov 15, 2013 at 02:28:37PM +0530, Kamalesh Babulal wrote:
> Move comments related to RT overload, above rto_count.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
>  kernel/sched/sched.h | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 88c85b21d633..ca452e63f203 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -372,19 +372,18 @@ struct rt_rq {
>   * fully partitioning the member cpus from any other cpuset. Whenever a new
>   * exclusive cpuset is created, we also create and attach a new root-domain
>   * object.
> - *
>   */
>  struct root_domain {
>  	atomic_t refcount;
> -	atomic_t rto_count;
> -	struct rcu_head rcu;
> -	cpumask_var_t span;
> -	cpumask_var_t online;

The span and online mask aren't actually related to the overload muck.

>  
>  	/*
>  	 * The "RT overload" flag: it gets set if a CPU has more than
>  	 * one runnable RT task.
>  	 */
> +	atomic_t rto_count;
> +	struct rcu_head rcu;
> +	cpumask_var_t span;
> +	cpumask_var_t online;
>  	cpumask_var_t rto_mask;
>  	struct cpupri cpupri;
>  };
> -- 
> 1.8.4.474.g128a96c
> 

      reply	other threads:[~2013-11-15 10:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15  8:58 Kamalesh Babulal
2013-11-15 10:07 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131115100715.GE2965@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®