mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH TRIVIAL] sched: Fix comments in struct root_domain
@ 2013-11-15  8:58 Kamalesh Babulal
  2013-11-15 10:07 ` Peter Zijlstra
  0 siblings, 1 reply; 2+ messages in thread
From: Kamalesh Babulal @ 2013-11-15  8:58 UTC (permalink / raw)
  To: linux-kernel; +Cc: Ingo Molnar, Peter Zijlstra

Move comments related to RT overload, above rto_count.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---
 kernel/sched/sched.h | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 88c85b21d633..ca452e63f203 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -372,19 +372,18 @@ struct rt_rq {
  * fully partitioning the member cpus from any other cpuset. Whenever a new
  * exclusive cpuset is created, we also create and attach a new root-domain
  * object.
- *
  */
 struct root_domain {
 	atomic_t refcount;
-	atomic_t rto_count;
-	struct rcu_head rcu;
-	cpumask_var_t span;
-	cpumask_var_t online;
 
 	/*
 	 * The "RT overload" flag: it gets set if a CPU has more than
 	 * one runnable RT task.
 	 */
+	atomic_t rto_count;
+	struct rcu_head rcu;
+	cpumask_var_t span;
+	cpumask_var_t online;
 	cpumask_var_t rto_mask;
 	struct cpupri cpupri;
 };
-- 
1.8.4.474.g128a96c


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH TRIVIAL] sched: Fix comments in struct root_domain
  2013-11-15  8:58 [PATCH TRIVIAL] sched: Fix comments in struct root_domain Kamalesh Babulal
@ 2013-11-15 10:07 ` Peter Zijlstra
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2013-11-15 10:07 UTC (permalink / raw)
  To: Kamalesh Babulal; +Cc: linux-kernel, Ingo Molnar

On Fri, Nov 15, 2013 at 02:28:37PM +0530, Kamalesh Babulal wrote:
> Move comments related to RT overload, above rto_count.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
>  kernel/sched/sched.h | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 88c85b21d633..ca452e63f203 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -372,19 +372,18 @@ struct rt_rq {
>   * fully partitioning the member cpus from any other cpuset. Whenever a new
>   * exclusive cpuset is created, we also create and attach a new root-domain
>   * object.
> - *
>   */
>  struct root_domain {
>  	atomic_t refcount;
> -	atomic_t rto_count;
> -	struct rcu_head rcu;
> -	cpumask_var_t span;
> -	cpumask_var_t online;

The span and online mask aren't actually related to the overload muck.

>  
>  	/*
>  	 * The "RT overload" flag: it gets set if a CPU has more than
>  	 * one runnable RT task.
>  	 */
> +	atomic_t rto_count;
> +	struct rcu_head rcu;
> +	cpumask_var_t span;
> +	cpumask_var_t online;
>  	cpumask_var_t rto_mask;
>  	struct cpupri cpupri;
>  };
> -- 
> 1.8.4.474.g128a96c
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-11-15 10:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-15  8:58 [PATCH TRIVIAL] sched: Fix comments in struct root_domain Kamalesh Babulal
2013-11-15 10:07 ` Peter Zijlstra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®