From: Peter Zijlstra <peterz@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Jonathan Corbet <corbet@lwn.net>, Dean Nelson <dcn@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>,
"Dr. H. Nikolaus Schaller" <hns@goldelico.com>,
Marek Belisko <marek@goldelico.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH/RFC] wait_for_completion_timeout() considered harmful.
Date: Tue, 19 Nov 2013 13:23:22 +0100 [thread overview]
Message-ID: <20131119122322.GM3866@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20131119195851.26bee8e6@notabene.brown>
On Tue, Nov 19, 2013 at 07:58:51PM +1100, NeilBrown wrote:
> /*
> * TODO: Make sure that we wait at least required delay but why we
> * have to extend it one tick more?
> */
> schedule_timeout_interruptible(msecs_to_jiffies(delay) + 2);
What makes me sad is that clearly people knew stuff was broken but
somehow it never got properly fixed.
Yes, changing something like this is risky, but I prefer to fix the
implementation to the sane and documented behaviour and fix up whatever
fallout that generates. The end result is saner code in general and less
new bugs.
next prev parent reply other threads:[~2013-11-19 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 21:06 NeilBrown
2013-11-18 23:27 ` Andrew Morton
2013-11-18 23:42 ` Peter Zijlstra
2013-11-19 0:49 ` Jonathan Corbet
2013-11-19 7:05 ` Ingo Molnar
2013-11-19 8:29 ` Peter Zijlstra
2013-11-18 23:44 ` NeilBrown
2013-11-19 8:25 ` Peter Zijlstra
2013-11-19 8:58 ` NeilBrown
2013-11-19 12:23 ` Peter Zijlstra [this message]
2013-11-19 14:39 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119122322.GM3866@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dcn@sgi.com \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome