From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 08/10] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation
Date: Tue, 19 Nov 2013 20:09:57 +0000 [thread overview]
Message-ID: <20131119200957.GS2674@sirena.org.uk> (raw)
In-Reply-To: <528BBE90.4020802@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Tue, Nov 19, 2013 at 08:40:00PM +0100, Lars-Peter Clausen wrote:
> On 11/19/2013 08:33 PM, Lee Jones wrote:
> > Despite the '+'s, I'm not actually adding these parameters, I'm
> > duplicating the pdata version and removing the stuff I 'know' that's
> > not required. I don't know what happens when/if these two parameters
> > are removed. I can add this to my TODO when I rip out platform data
> > support, which will happen when this stuff lands.
> I think the patch is fine for now. Once non-DT support has been removed for
> ux500 we should be able to remove the whole ux500_pcm.c file (Assuming that
> the ux500 DMA engine driver gains dma_slave_caps support).
Yeah, it shouldn't break anything but I'd rather at least have a comment
on any new code that specifies these things by hand explaining why the
automatic stuff doesn't work, it's much nicer to not have to specify the
magic numbers by hand and this will help encourage new code to do the
right thing.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-19 20:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 11:07 [PATCH 00/10] ASoC: dma: ARM: ux500: Obtain DMA data from Device Tree Lee Jones
2013-11-19 11:07 ` [PATCH 01/10] dma: ste_dma40: Expand DT binding to accept 'high-priority channel' flag Lee Jones
2013-11-19 21:02 ` Linus Walleij
2013-11-19 11:07 ` [PATCH 02/10] dma: ste_dma40: Parse flags property for new 'high priority channel' request Lee Jones
2013-11-19 21:03 ` Linus Walleij
2013-11-19 11:07 ` [PATCH 03/10] ARM: ux500: Don't use enums for MSP IDs - for easy DT conversion Lee Jones
2013-11-19 11:07 ` [PATCH 04/10] ARM: ux500: Add DMA config bindings for MSP devices Lee Jones
2013-11-19 21:06 ` Linus Walleij
2013-11-19 11:07 ` [PATCH 05/10] ASoC: Ux500: Match platform by device node when booting Device Tree Lee Jones
2013-11-19 18:49 ` Mark Brown
2013-11-19 11:07 ` [PATCH 06/10] ASoC: ux500_pcm: Extend Device Tree support to deal with DMA data Lee Jones
2013-11-19 18:50 ` Mark Brown
2013-11-19 11:07 ` [PATCH 07/10] ASoC: ux500: Store DMA data in the DAI differently in the pdata and DT case Lee Jones
2013-11-19 18:51 ` Mark Brown
2013-12-02 7:35 ` [alsa-devel] " Olof Johansson
2013-12-02 10:12 ` Lee Jones
2013-12-02 13:54 ` Mark Brown
2013-12-02 14:03 ` Lee Jones
2013-12-02 14:04 ` Mark Brown
2013-12-04 17:45 ` Kevin Hilman
2013-12-04 18:03 ` Lee Jones
2013-11-19 11:07 ` [PATCH 08/10] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Lee Jones
2013-11-19 18:48 ` Mark Brown
2013-11-19 19:33 ` Lee Jones
2013-11-19 19:40 ` Lars-Peter Clausen
2013-11-19 20:09 ` Mark Brown [this message]
2013-11-19 11:07 ` [PATCH 09/10] ASoC: ux500_pcm: Take out pointless dev_dbg() call Lee Jones
2013-11-19 18:51 ` Mark Brown
2013-11-19 11:07 ` [PATCH 10/10] ASoC: ux500: Dynamically fill DAI driver data on probe Lee Jones
2013-11-19 18:53 ` [PATCH 00/10] ASoC: dma: ARM: ux500: Obtain DMA data from Device Tree Mark Brown
2013-11-29 16:03 ` Lee Jones
2013-11-29 16:42 ` Mark Brown
2013-11-29 17:37 ` Lee Jones
2013-11-29 18:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119200957.GS2674@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®