mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 10/22] tools lib traceevent: Add function plugin
Date: Thu, 21 Nov 2013 08:20:04 -0500	[thread overview]
Message-ID: <20131121082004.0f74915f@gandalf.local.home> (raw)
In-Reply-To: <1385031680-9014-11-git-send-email-jolsa@redhat.com>

On Thu, 21 Nov 2013 12:01:08 +0100
Jiri Olsa <jolsa@redhat.com> wrote:

> Backporting function plugin.
> 
> Backported from Steven Rostedt's trace-cmd repo (HEAD 0f2c2fb):
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git
> 
> This plugin adds function and parent function fields
> resolving for ftrace:function tracepoint event.
> 
> The diff of 'perf script' output generated by old and new code:
> (data was generated by 'perf record -e ftrace:function ls')
> 
> --- script.function.old
> +++ script.function.new
> -              ls 10781 [001] 32667.291379: ftrace:function:  ffffffff811adb80 <-- ffffffff811afc48
> -              ls 10781 [001] 32667.291379: ftrace:function:  ffffffff811b35d0 <-- ffffffff811adb9b
> -              ls 10781 [001] 32667.291380: ftrace:function:  ffffffff811b3520 <-- ffffffff811b35e8
> -              ls 10781 [001] 32667.291380: ftrace:function:  ffffffff811b2720 <-- ffffffff811b3549
> -              ls 10781 [001] 32667.291381: ftrace:function:  ffffffff81297e10 <-- ffffffff811b356c
> -              ls 10781 [001] 32667.291381: ftrace:function:  ffffffff81298f40 <-- ffffffff81297e2c
> -              ls 10781 [001] 32667.291382: ftrace:function:  ffffffff81076160 <-- ffffffff811afbf0
> -              ls 10781 [001] 32667.291383: ftrace:function:  ffffffff811c3eb0 <-- ffffffff811afbfc
> -              ls 10781 [001] 32667.291383: ftrace:function:  ffffffff8164e100 <-- ffffffff811c3ed8
> -              ls 10781 [001] 32667.291384: ftrace:function:  ffffffff811a5d10 <-- ffffffff811c3f53
> -              ls 10781 [001] 32667.291384: ftrace:function:  ffffffff811e8e70 <-- ffffffff811a5d58
> -              ls 10781 [001] 32667.291385: ftrace:function:  ffffffff811f38e0 <-- ffffffff811a5d63
> -              ls 10781 [001] 32667.291385: ftrace:function:  ffffffff811a9ff0 <-- ffffffff811a5d6b
> -              ls 10781 [001] 32667.291386: ftrace:function:  ffffffff811a9fa0 <-- ffffffff811aa015
> -              ls 10781 [001] 32667.291387: ftrace:function:  ffffffff810851c0 <-- ffffffff811aa053
> -              ls 10781 [001] 32667.291387: ftrace:function:  ffffffff81090e00 <-- ffffffff81085211
> +              ls 10781 [001] 32667.291379: ftrace:function: would_dump <-- setup_new_exec
> +              ls 10781 [001] 32667.291379: ftrace:function:    inode_permission <-- would_dump
> +              ls 10781 [001] 32667.291380: ftrace:function:       __inode_permission <-- inode_permission
> +              ls 10781 [001] 32667.291380: ftrace:function:          generic_permission <-- __inode_permission
> +              ls 10781 [001] 32667.291381: ftrace:function:          security_inode_permission <-- __inode_permission
> +              ls 10781 [001] 32667.291381: ftrace:function:             cap_inode_permission <-- security_inode_permission
> +              ls 10781 [001] 32667.291382: ftrace:function: flush_signal_handlers <-- setup_new_exec
> +              ls 10781 [001] 32667.291383: ftrace:function: do_close_on_exec <-- setup_new_exec
> +              ls 10781 [001] 32667.291383: ftrace:function:    _raw_spin_lock <-- do_close_on_exec
> +              ls 10781 [001] 32667.291384: ftrace:function:    filp_close <-- do_close_on_exec
> +              ls 10781 [001] 32667.291384: ftrace:function:       dnotify_flush <-- filp_close
> +              ls 10781 [001] 32667.291385: ftrace:function:       locks_remove_posix <-- filp_close
> +              ls 10781 [001] 32667.291385: ftrace:function:       fput <-- filp_close
> +              ls 10781 [001] 32667.291386: ftrace:function:          file_sb_list_del <-- fput
> +              ls 10781 [001] 32667.291387: ftrace:function:          task_work_add <-- fput
> +              ls 10781 [001] 32667.291387: ftrace:function:             kick_process <-- task_work_add
> 
> Removing options support as it's not backported yet.
> Currently this plugin supports 2 options:
>  'parent' to display parent function

The number of times I enabled the parent option, I should make it
default too.

Thanks!

>  'indent' to show function call indents
> 
> Enabling both of them by default.
> 
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> Cc: David Ahern <dsahern@gmail.com>
> ---
>  tools/lib/traceevent/Makefile          |   1 +
>  tools/lib/traceevent/plugin_function.c | 151 +++++++++++++++++++++++++++++++++
>  2 files changed, 152 insertions(+)
>  create mode 100644 tools/lib/traceevent/plugin_function.c
> 


  reply	other threads:[~2013-11-21 13:20 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21 11:00 [PATCH 00/22] perf tools: Add traceevent plugins support Jiri Olsa
2013-11-21 11:00 ` [PATCH 01/22] tools lib traceevent: Add plugin support Jiri Olsa
2013-11-21 11:58   ` Steven Rostedt
2013-11-22 14:17   ` Namhyung Kim
2013-11-23  8:12     ` Steven Rostedt
2013-11-25  7:33       ` Namhyung Kim
2013-11-25  9:30       ` Jiri Olsa
2013-11-21 11:01 ` [PATCH 02/22] tools lib traceevent: Add plugin build support Jiri Olsa
2013-11-21 11:01 ` [PATCH 03/22] tools lib traceevent: Add traceevent_host_bigendian function Jiri Olsa
2013-11-22 14:22   ` Namhyung Kim
2013-11-23  8:27     ` Steven Rostedt
2013-11-25  7:24       ` Namhyung Kim
2013-11-25  9:33         ` Jiri Olsa
2013-11-21 11:01 ` [PATCH 04/22] tools lib traceevent: Add jbd2 plugin Jiri Olsa
2013-11-21 13:09   ` Steven Rostedt
2013-11-22 14:27   ` Namhyung Kim
2013-11-23  8:52     ` Steven Rostedt
2013-11-25  7:38       ` Namhyung Kim
2013-11-25  9:46       ` Jiri Olsa
2013-11-25 10:03         ` Jiri Olsa
2013-11-21 11:01 ` [PATCH 05/22] tools lib traceevent: Add hrtimer plugin Jiri Olsa
2013-11-21 13:10   ` Steven Rostedt
2013-11-22 14:33   ` Namhyung Kim
2013-11-23  8:59     ` Steven Rostedt
2013-11-21 11:01 ` [PATCH 06/22] tools lib traceevent: Add kmem plugin Jiri Olsa
2013-11-21 13:14   ` Steven Rostedt
2013-11-22 14:38   ` Namhyung Kim
2013-11-23  9:06     ` Steven Rostedt
2013-11-25  7:43       ` Namhyung Kim
2013-11-21 11:01 ` [PATCH 07/22] tools lib traceevent: Add kvm plugin Jiri Olsa
2013-11-21 13:15   ` Steven Rostedt
2013-11-22 14:45   ` Namhyung Kim
2013-11-23  9:15     ` Steven Rostedt
2013-11-21 11:01 ` [PATCH 08/22] tools lib traceevent: Add mac80211 plugin Jiri Olsa
2013-11-21 11:01 ` [PATCH 09/22] tools lib traceevent: Add sched_switch plugin Jiri Olsa
2013-11-21 13:18   ` Steven Rostedt
     [not found]   ` <1385132034.1747.58.camel@leonhard>
2013-11-23  9:16     ` Steven Rostedt
2013-11-21 11:01 ` [PATCH 10/22] tools lib traceevent: Add function plugin Jiri Olsa
2013-11-21 13:20   ` Steven Rostedt [this message]
2013-11-22 15:03   ` Namhyung Kim
2013-11-23  9:22     ` Steven Rostedt
2013-11-21 11:01 ` [PATCH 11/22] tools lib traceevent: Add xen plugin Jiri Olsa
2013-11-22 15:06   ` Namhyung Kim
2013-11-25 13:38     ` Jiri Olsa
2013-11-21 11:01 ` [PATCH 12/22] tools lib traceevent: Add scsi plugin Jiri Olsa
2013-11-22 15:24   ` Namhyung Kim
2013-11-23  9:25     ` Steven Rostedt
2013-11-21 11:01 ` [PATCH 13/22] tools lib traceevent: Add cfg80211 plugin Jiri Olsa
2013-11-22 15:16   ` Namhyung Kim
2013-11-23  9:27     ` Steven Rostedt
2013-11-21 11:01 ` [PATCH 14/22] tools lib traceevent: Update kvm plugin with is_writable_pte helper Jiri Olsa
2013-11-22 15:19   ` Namhyung Kim
2013-11-23  9:28     ` Steven Rostedt
2013-11-21 11:01 ` [PATCH 15/22] tools lib traceevent: Change pevent_parse_event to return event format Jiri Olsa
2013-11-21 13:28   ` Steven Rostedt
2013-11-21 13:42     ` Jiri Olsa
2013-11-21 11:01 ` [PATCH 16/22] tools lib traceevent: Harmonize the install messages in lib-traceevent Jiri Olsa
2013-11-21 11:01 ` [PATCH 17/22] perf tools: Add build and install plugins targets Jiri Olsa
2013-11-22 15:27   ` Namhyung Kim
2013-11-25 14:51     ` Jiri Olsa
2013-11-27  8:13       ` Namhyung Kim
2013-11-21 11:01 ` [PATCH 18/22] perf tools: Add udis86 disassembler feature check Jiri Olsa
2013-11-22 15:38   ` Namhyung Kim
2013-11-25 15:02     ` Jiri Olsa
2013-11-21 11:01 ` [PATCH 19/22] perf tools: Add filename__read_str util function Jiri Olsa
2013-11-22 15:43   ` Namhyung Kim
2013-11-25 15:17     ` Jiri Olsa
2013-11-21 11:01 ` [PATCH 20/22] perf tools: Add trace-event object Jiri Olsa
2013-11-21 11:01 ` [PATCH 21/22] perf tools: Add trace-event global object for tracepoint interface Jiri Olsa
2013-11-22 15:47   ` Namhyung Kim
2013-11-25 16:03     ` Jiri Olsa
2013-11-27 13:46       ` Namhyung Kim
2013-11-27 15:10         ` Jiri Olsa
2013-11-27 15:27           ` Jiri Olsa
2013-11-27 15:49             ` Namhyung Kim
2013-11-21 11:01 ` [PATCH 22/22] perf tools: Overload pr_stat traceevent print function Jiri Olsa
2013-11-22 15:50   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131121082004.0f74915f@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®