Re: [PATCH 11/22] tools lib traceevent: Add xen plugin

[Jiri Olsa <jolsa@redhat.com>]

On Sat, Nov 23, 2013 at 12:06:28AM +0900, Namhyung Kim wrote:
> 2013-11-21 (목), 12:01 +0100, Jiri Olsa:
> > Adding xen plugin.
> > 
> > This plugin adds fields resolving for
> > following tracepoint events:
> >   xen:xen_mc_entry
> >   xen:xen_mc_extend_args
> > 
> > The diff of 'perf script' output generated by old and new code:
> > (data was generated by 'perf record -e 'xen:*' ls')
> > 
> > --- script.xen.old
> > +++ script.xen.new
> > -         swapper     0 [002]   136.267492: xen:xen_mc_entry: [FAILED TO PARSE] op=3 nargs=2 args=ARRAY[18, 00, 00, 00, 00, 00, 00, 00, 00, e0, d4, 4b, 04, 88, ff, ff, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> > +         swapper     0 [002]   136.267492: xen:xen_mc_entry: op 3(stack_switch) args [18, 0, 0, 0, 0, 0]
> > -            perf  1970 [008]   136.273319: xen:xen_mc_extend_args: [FAILED TO PARSE] op=1 args=16 res=1
> > +            perf  1970 [008]   136.273319: xen:xen_mc_extend_args: extending op 1(mmu_update) by 16 bytes res ???
> > 
> > NOTE We still do not handle the 'sizeof' and fail
> > to parse following xen tracepoints:
> >   xen:xen_mmu_set_pte
> >   xen:xen_mmu_set_pte_atomic
> >   xen:xen_mmu_set_domain_pte
> >   xen:xen_mmu_set_pte_at
> >   xen:xen_mmu_set_pmd
> >   xen:xen_mmu_set_pud
> >   xen:xen_mmu_set_pgd
> >   xen:xen_mmu_ptep_modify_prot_start
> >   xen:xen_mmu_ptep_modify_prot_commit
> > 
> 
> [SNIP]
> > +static const char *xen_hypercall_name(unsigned op)
> > +{
> > +	if (op < ARRAY_SIZE(xen_hypercall_names) &&
> > +	    xen_hypercall_names[op] != NULL)
> > +		return xen_hypercall_names[op];
> > +
> > +	return "";
> 
> How about defaults to "unknown" if not found?
> 

That's how the kernel 'xen_hypercall_name' handles it.

I dont mind, but I guess we want to change both sides.
I've already included Jeremy (kernel side author), so
I guess it's up to him ;-)

jirka