From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Ian.Campbell@citrix.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org, JBeulich@suse.com,
boris.ostrovsky@oracle.com
Subject: Re: [PATCH 2/4] xen/manage: Poweroff forcefully if user-space is not yet up.
Date: Tue, 26 Nov 2013 11:47:03 -0500 [thread overview]
Message-ID: <20131126164703.GG2959@phenom.dumpdata.com> (raw)
In-Reply-To: <528DEF9D.4070003@citrix.com>
On Thu, Nov 21, 2013 at 11:33:49AM +0000, David Vrabel wrote:
> On 08/11/13 17:38, Konrad Rzeszutek Wilk wrote:
> > The user can launch the guest in this sequence:
> >
> > xl create -p /vm.cfg [launch, but pause it]
> > xl shutdown latest [sets control/shutdown=poweroff]
> > xl unpause latest
> > xl console latest [and see that the guest has completely
> > ignored the shutdown request]
> >
> > In reality the guest hasn't ignored it. It registers a watch
> > and gets a notification that there is value. It then calls
> > the shutdown_handler which ends up calling orderly_shutdown.
>
> Is this really a bug?.
Yes. We did get the action, we just did not properly act on it.
>
> >From the xl(1) man page.
>
> shutdown [OPTIONS] -a|domain-id
> Gracefully shuts down a domain. This coordinates with the
> domain OS to perform graceful shutdown, so there is no guarantee
> that it will succeed, and may take a variable length of time
> depending on what services must be shutdown in the domain.
>
> Seems like ignoring a shutdown request when the guest cannot yet
> shutdown gracefully is the expected behaviour.
>
> This also doesn't seem sufficient. SYSTEM_RUNNING is set prior to
> starting init in an initramfs and orderly_power_off(false) will still
> likely fail at this point.
Ugh, will have to figure out how else to realize when it the user-space
is ready to launch programs.
>
> David
next prev parent reply other threads:[~2013-11-26 16:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 17:38 [PATCH] Fixes to Linux v3.13 - bugs.xenproject.org ones. (v1) Konrad Rzeszutek Wilk
2013-11-08 17:38 ` [PATCH 1/4] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved for MCFG areas Konrad Rzeszutek Wilk
2013-11-21 10:37 ` David Vrabel
2013-11-08 17:38 ` [PATCH 2/4] xen/manage: Poweroff forcefully if user-space is not yet up Konrad Rzeszutek Wilk
2013-11-20 21:11 ` Boris Ostrovsky
2013-11-21 11:33 ` David Vrabel
2013-11-26 16:47 ` Konrad Rzeszutek Wilk [this message]
2014-04-01 15:43 ` Konrad Rzeszutek Wilk
2013-11-08 17:38 ` [PATCH 3/4] xen/manage: Guard against user-space initiated poweroff and XenBus Konrad Rzeszutek Wilk
2013-11-20 21:40 ` Boris Ostrovsky
2013-11-21 11:09 ` David Vrabel
2013-11-26 16:45 ` Konrad Rzeszutek Wilk
2013-12-02 11:27 ` David Vrabel
2014-03-31 19:09 ` Konrad Rzeszutek Wilk
2014-04-01 13:18 ` David Vrabel
2014-04-01 14:03 ` Konrad Rzeszutek Wilk
2013-11-08 17:38 ` [PATCH 4/4] xen/xenbus: Avoid synchronous wait on XenBus stalling shutdown/restart Konrad Rzeszutek Wilk
2013-11-21 17:52 ` [Xen-devel] " David Vrabel
2013-11-22 9:30 ` Ian Campbell
2013-11-26 16:50 ` Konrad Rzeszutek Wilk
2013-12-02 11:41 ` David Vrabel
2014-03-31 20:33 ` Konrad Rzeszutek Wilk
2014-04-01 12:53 ` David Vrabel
2014-01-26 1:13 ` Zhang, Yang Z
2014-01-26 3:44 ` Konrad Rzeszutek Wilk
2014-04-03 11:59 ` [PATCH] Fixes to Linux v3.13 - bugs.xenproject.org ones. (v1) David Vrabel
2014-04-03 18:07 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126164703.GG2959@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome