From: Mark Brown <broonie@kernel.org>
To: Li Xiubo <Li.Xiubo@freescale.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.de" <tiwai@suse.de>,
Fabio Estevam <Fabio.Estevam@freescale.com>,
"LW@KARO-electronics.de" <LW@KARO-electronics.de>,
"oskar@scara.com" <oskar@scara.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv1] ASoC: SGTL5000: Fix kernel failed while getting regulator consumers
Date: Wed, 27 Nov 2013 11:27:25 +0000 [thread overview]
Message-ID: <20131127112725.GT14725@sirena.org.uk> (raw)
In-Reply-To: <1DD289F6464F0949A2FCA5AA6DC23F828CE2A8@039-SN2MPN1-012.039d.mgd.msft.net>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On Wed, Nov 27, 2013 at 08:13:03AM +0000, Li Xiubo wrote:
Please fix your mailer to word wrap within paragraphs, it makes your
mail much more legible.
> There is one dependency patch: "regulator: core: Provide a dummy regulator with full constraints".
> From the dependency patch, we can see that using regulator_get_optional() instead can resovle the problem you descripted above.
> When or will this dependency patch be merged into the -next tree ?
That patch is already in mainline.
> > I'd expect to see a commit description that describes how the driver
> > currently tries to handle this, why it doesn't work and how the patch
> > fixes it.
> The SGTL5000 requires 2 external power supplies: VDDA and VDDIO. An
> optional third external power supply VDDD may be provided externally
You need to put your working through of this stuff in the commit
message.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-27 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 9:55 Xiubo Li
2013-11-26 10:59 ` Lothar Waßmann
2013-11-27 4:16 ` Li Xiubo
2013-11-26 13:44 ` Mark Brown
2013-11-27 8:13 ` Li Xiubo
2013-11-27 11:27 ` Mark Brown [this message]
2013-11-28 3:31 ` Li Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127112725.GT14725@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Fabio.Estevam@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oskar@scara.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®