mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts
Date: Wed, 27 Nov 2013 13:53:10 -0800	[thread overview]
Message-ID: <20131127215310.GC26766@atomide.com> (raw)
In-Reply-To: <20131124213651.59750C402C3@trevor.secretlab.ca>

* Grant Likely <grant.likely@linaro.org> [131124 13:37]:
> 
> I actually like the idea of completely allocating the resource structure
> but leaving some entries empty. However, I agree with rmk that putting
> garbage into a resource structure is a bad idea. What about changing the
> value of flags to 0 or some other value to be obviously an empty
> property and give the follow up parsing some context about which ones it
> needs to attempt to recalculate?

If we want to play it safe, we should probably introduce something like
this to ioport.h:

+#define IORESOURCE_IRQ_DEFERRED	(1<<6)

Then we can populate IRQ resources initially with that. And later on
during the driver probe, we know it's safe to populate the resource
if res->flags & IORESOURCE_IRQ_DEFERRED.

That fixes the $Subject bug, and gets us a little bit further for
making more changes later on.

Regards,

Tony

  parent reply	other threads:[~2013-11-27 21:53 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-23  0:43 Tony Lindgren
2013-11-23  0:55 ` Russell King - ARM Linux
2013-11-23  1:08   ` Tony Lindgren
2013-11-23  1:15     ` Tony Lindgren
2013-11-23  1:50       ` Tony Lindgren
2013-11-23 15:42         ` Rob Herring
2013-11-23 16:32           ` Tony Lindgren
2013-11-25  9:34             ` Thierry Reding
2013-11-25 19:46               ` Tony Lindgren
2013-11-24 21:27         ` Grant Likely
2013-12-10  3:39           ` Paul Walmsley
2013-12-30 22:10             ` Paul Walmsley
2013-12-31 16:33               ` Rob Herring
2014-01-06 23:41                 ` Paul Walmsley
2014-01-08  1:19                   ` Tony Lindgren
2014-01-08 12:51                     ` [PATCH] driver-core: platform: Resolve DT interrupt references late Thierry Reding
2014-01-08 13:41                       ` Arnd Bergmann
2014-01-08 14:55                         ` Thierry Reding
2014-01-08 15:11                           ` Arnd Bergmann
2014-01-08 15:58                             ` Thierry Reding
2014-01-08 16:25                               ` Arnd Bergmann
2014-01-08 19:59                                 ` Thierry Reding
2014-01-08 20:09                                   ` Arnd Bergmann
2014-01-08 20:24                                     ` Thierry Reding
2014-01-08 21:01                                       ` Arnd Bergmann
2014-01-08 16:40                       ` Tony Lindgren
2014-01-08 19:28                         ` Thierry Reding
2014-01-08 21:43                           ` Tony Lindgren
2013-11-23  1:07 ` [PATCH] of/platform: Fix no irq domain found errors when populating interrupts Tony Lindgren
2013-11-24 21:36 ` Grant Likely
2013-11-25  9:25   ` Thierry Reding
     [not found]     ` < 20131125094954.GF22043@ulmo.nvidia.com>
2013-11-25  9:49     ` Thierry Reding
2013-11-25 19:50       ` Tony Lindgren
2013-11-27 15:56       ` Grant Likely
2013-11-28 15:46         ` Thierry Reding
2013-12-11 13:45           ` Grant Likely
2013-12-11 15:12             ` Thierry Reding
2013-12-11 16:43               ` Tony Lindgren
2013-11-27 15:54     ` Grant Likely
2013-11-27 21:53   ` Tony Lindgren [this message]
2014-04-10 21:38 Tony Lindgren
2014-04-11  0:29 ` Rob Herring
2014-04-11 18:43   ` Thierry Reding
2014-04-18 20:55     ` Tony Lindgren
2014-04-11  9:20 ` Russell King - ARM Linux
2014-04-11 18:36   ` Thierry Reding
2014-04-18 21:37     ` Tony Lindgren
2014-04-18 23:18       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131127215310.GC26766@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome