mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Tony Lindgren <tony@atomide.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Grant Likely <grant.likely@linaro.org>,
	Paul Walmsley <paul@pwsan.com>,
	Rob Herring <robherring2@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts
Date: Sat, 19 Apr 2014 00:18:17 +0100	[thread overview]
Message-ID: <20140418231817.GJ24070@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140418213751.GC21823@atomide.com>

On Fri, Apr 18, 2014 at 02:37:51PM -0700, Tony Lindgren wrote:
> * Thierry Reding <thierry.reding@gmail.com> [140411 11:40]:
> > On Fri, Apr 11, 2014 at 10:20:28AM +0100, Russell King - ARM Linux wrote:
> > > So what happens if a device driver probe function:
> > > 
> > > - creates a new platform device
> > > - copies the resources from the original to the new device
> > > - copies the of_node from the original to the new device
> > > - registers the new device
> > > 
> > > Yes, it's broken (because it can result in the same driver being re-probed
> > > by the new device) but we *do* have stuff in the kernel tree which does
> > > this.
> 
> Grr. Care to list some examples? See also if what I'm suggesting below
> if that might work for the cases you're describing.

Until recently, ahci_imx did exactly this, but that's been fixed now
(by reworking ahci into a library.)  I'm not immediately aware of any
other drivers pulling this trick.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

  reply	other threads:[~2014-04-18 23:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 21:38 Tony Lindgren
2014-04-11  0:29 ` Rob Herring
2014-04-11 18:43   ` Thierry Reding
2014-04-18 20:55     ` Tony Lindgren
2014-04-11  9:20 ` Russell King - ARM Linux
2014-04-11 18:36   ` Thierry Reding
2014-04-18 21:37     ` Tony Lindgren
2014-04-18 23:18       ` Russell King - ARM Linux [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-11-23  0:43 Tony Lindgren
2013-11-23  0:55 ` Russell King - ARM Linux
2013-11-23  1:08   ` Tony Lindgren
2013-11-23  1:15     ` Tony Lindgren
2013-11-23  1:50       ` Tony Lindgren
2013-11-23 15:42         ` Rob Herring
2013-11-23 16:32           ` Tony Lindgren
2013-11-25  9:34             ` Thierry Reding
2013-11-25 19:46               ` Tony Lindgren
2013-11-24 21:27         ` Grant Likely
2013-12-10  3:39           ` Paul Walmsley
2013-12-30 22:10             ` Paul Walmsley
2013-12-31 16:33               ` Rob Herring
2014-01-06 23:41                 ` Paul Walmsley
2014-01-08  1:19                   ` Tony Lindgren
2013-11-23  1:07 ` Tony Lindgren
2013-11-24 21:36 ` Grant Likely
2013-11-25  9:25   ` Thierry Reding
     [not found]     ` < 20131125094954.GF22043@ulmo.nvidia.com>
2013-11-25  9:49     ` Thierry Reding
2013-11-25 19:50       ` Tony Lindgren
2013-11-27 15:56       ` Grant Likely
2013-11-28 15:46         ` Thierry Reding
2013-12-11 13:45           ` Grant Likely
2013-12-11 15:12             ` Thierry Reding
2013-12-11 16:43               ` Tony Lindgren
2013-11-27 15:54     ` Grant Likely
2013-11-27 21:53   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140418231817.GJ24070@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=arnd@arndb.de \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=robherring2@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®