From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gary Rookard <garyrookard@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
lisa@xenapiadmin.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Staging: bcm: DDRInit: Fixed coding style issue, replaced spaces w/ tabs.(patch set)
Date: Thu, 5 Dec 2013 11:57:36 +0300 [thread overview]
Message-ID: <20131205085736.GY28413@mwanda> (raw)
In-Reply-To: <1386203179-21041-1-git-send-email-garyrookard@gmail.com>
These five patches all do the same thing. It's ok to merge them into
one patch.
The subject lines are all the same and that's not ok. The subject lines
are too long as well.
On Wed, Dec 04, 2013 at 07:26:19PM -0500, Gary Rookard wrote:
> This is the first patch of a series.
Don't put this in the description.
> Replaced spaces in margin w/ 1 tab for lines:
> 11-15, 17-23, 25-58, 60, 62, 64
>
No signed off by line.
> On branch staging-next
Put this between the --- and the diffstat.
> ---
<-- here.
> drivers/staging/bcm/DDRInit.c | 98 +++++++++++++++++++++----------------------
> 1 file changed, 49 insertions(+), 49 deletions(-)
regards,
dan carpenter
prev parent reply other threads:[~2013-12-05 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 0:26 Gary Rookard
2013-12-05 8:57 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205085736.GY28413@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=garyrookard@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome