mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Boris BREZILLON <b.brezillon@overkiz.com>
Cc: Rob Landley <rob@landley.net>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Jiri Prchal <jiri.prchal@aksignal.cz>,
	Ben Gamari <bgamari.foss@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH] gpio: add GPIO hogging mechanism
Date: Thu, 19 Dec 2013 08:41:09 -0800	[thread overview]
Message-ID: <20131219164109.GB27409@kroah.com> (raw)
In-Reply-To: <1387463671-1164-2-git-send-email-b.brezillon@overkiz.com>

On Thu, Dec 19, 2013 at 03:34:31PM +0100, Boris BREZILLON wrote:
> GPIO hogging is a way to request and configure specific GPIO without
> explicitly requesting it in the device driver.
> 
> The request and configuration procedure is handled in the core device
> driver code before the driver probe function is called.
> 
> It allows specific GPIOs to be configured without any driver specific code.
> 
> Particularly usefull when a external device is connected to a bus and the
> bus connections depends on an external switch controlled by a GPIO pin.
> Or when some GPIOs have to be exported to sysfs without any userspace
> intervention.
> 
> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
> ---
>  Documentation/devicetree/bindings/gpio/gpio.txt |   47 ++++++++
>  drivers/base/Makefile                           |    1 +
>  drivers/base/dd.c                               |    5 +
>  drivers/base/gpio.c                             |   59 ++++++++++

I don't understand what makes GPIO's "special" enough to get included in
the driver core like this, and called for each and every device that is
added to the system.

What's wrong with the generic device callbacks/notifiers we already
have?  Why does this need to be in the driver core?  And what exactly
are you doing all of this for in the first place?

greg k-h

  reply	other threads:[~2013-12-19 16:41 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 14:34 Boris BREZILLON
2013-12-19 14:34 ` Boris BREZILLON
2013-12-19 16:41   ` Greg Kroah-Hartman [this message]
2013-12-19 16:47     ` Felipe Balbi
2013-12-19 17:18       ` boris brezillon
2013-12-19 18:22         ` Felipe Balbi
2013-12-30  9:48           ` boris brezillon
2014-01-08  9:45             ` Linus Walleij
2013-12-19 17:13     ` boris brezillon
2014-09-20 21:37     ` Ben Gamari
2014-09-20 22:26       ` Ben Gamari
2014-01-08  9:37   ` Linus Walleij
2014-01-08 10:18     ` boris brezillon
2014-01-14 10:27       ` Linus Walleij
2014-10-06 11:58 [GIT PULL] bulk pin control changes for v3.18 Linus Walleij
2014-10-06 15:37 ` [RFC PATCH] gpio: add GPIO hogging mechanism Benoit Parrot
2014-10-21 10:55   ` Linus Walleij
2014-10-21 20:09 [RFC Patch] " Benoit Parrot
2014-10-29  7:09 ` Alexandre Courbot
2014-10-29 16:21   ` Benoit Parrot
2014-10-30  0:29     ` Alexandre Courbot
2014-11-14  9:19   ` Linus Walleij
2014-11-14 10:22     ` Maxime Ripard
2014-10-29  8:53 ` Pantelis Antoniou
2014-10-29 16:34   ` Benoit Parrot
2014-10-29 16:42     ` Pantelis Antoniou
2014-10-29 19:36       ` Benoit Parrot
2014-10-30  0:31       ` Alexandre Courbot
2014-11-03  9:43   ` Linus Walleij
2014-10-29 10:45 ` Maxime Ripard
2014-10-29 16:41   ` Benoit Parrot
2014-10-29 16:47     ` Maxime Ripard
2014-10-29 23:09       ` Benoit Parrot
2014-10-30 17:16         ` Maxime Ripard
2014-11-03  9:59 ` Linus Walleij
2014-11-04  0:38   ` Benoit Parrot
2014-11-14  9:16     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131219164109.GB27409@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=b.brezillon@overkiz.com \
    --cc=bgamari.foss@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=jiri.prchal@aksignal.cz \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®