From: Mark Brown <broonie@kernel.org>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: lgirdwood@gmail.com, grant.likely@linaro.org,
rob.herring@calxeda.com, plagnioj@jcrosoft.com,
nicolas.ferre@atmel.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/3] regulator: act8865: add PMIC act8865 driver
Date: Tue, 24 Dec 2013 13:51:27 +0000 [thread overview]
Message-ID: <20131224135127.GC24814@sirena.org.uk> (raw)
In-Reply-To: <1387852468-18073-1-git-send-email-wenyou.yang@atmel.com>
On Tue, Dec 24, 2013 at 10:34:28AM +0800, Wenyou Yang wrote:
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
I've applied this, however there is one small issue which I seem to have
forgotten to point out previously:
> + /* Finally register devices */
> + for (i = 0; i < pdata->num_regulators; i++) {
The driver should register all regulators regardless of how many are
used in the system in order to aid diagnostics. Please send an
incremental patch to fix this.
next prev parent reply other threads:[~2013-12-24 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 2:33 [PATCH v5 0/3] regulator: act8865: add PMIC driver Wenyou Yang
2013-12-24 2:34 ` [PATCH v5 1/3] regulator: act8865: add PMIC act8865 driver Wenyou Yang
2013-12-24 13:51 ` Mark Brown [this message]
2013-12-24 2:35 ` [PATCH v5 2/3] regulator: act8865: add device tree binding doc Wenyou Yang
2013-12-24 13:49 ` Mark Brown
2013-12-24 2:36 ` [PATCH v5 3/3] ARM: dts: sama5d3xcm: add the regulator device node Wenyou Yang
2014-04-18 21:25 ` Nicolas Ferre
2014-04-21 3:08 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131224135127.GC24814@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®