From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Yijing Wang <wangyijing@huawei.com>, JBeulich@suse.com
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci device
Date: Tue, 31 Dec 2013 09:51:11 -0500 [thread overview]
Message-ID: <20131231145111.GB3349@phenom.dumpdata.com> (raw)
In-Reply-To: <1386243245-34280-1-git-send-email-wangyijing@huawei.com>
On Thu, Dec 05, 2013 at 07:34:05PM +0800, Yijing Wang wrote:
> Use PCI standard marco dev_is_pci() instead of directly compare
> pci_bus_type to check whether it is pci device.
Jan, you OK with this?
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> ---
> drivers/xen/dbgp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
> index f3ccc80..8145a59 100644
> --- a/drivers/xen/dbgp.c
> +++ b/drivers/xen/dbgp.c
> @@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
> dbgp.op = op;
>
> #ifdef CONFIG_PCI
> - if (ctrlr->bus == &pci_bus_type) {
> + if (dev_is_pci(ctrlr)) {
> const struct pci_dev *pdev = to_pci_dev(ctrlr);
>
> dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
> --
> 1.7.1
>
>
next prev parent reply other threads:[~2013-12-31 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 11:34 Yijing Wang
2013-12-31 14:51 ` Konrad Rzeszutek Wilk [this message]
2014-01-07 12:16 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231145111.GB3349@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wangyijing@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome