Re: [PATCH] xen: Use dev_is_pci() to check whether it is pci device

["Jan Beulich" <JBeulich@suse.com>]

>>> On 31.12.13 at 15:51, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> On Thu, Dec 05, 2013 at 07:34:05PM +0800, Yijing Wang wrote:
>> Use PCI standard marco dev_is_pci() instead of directly compare
>> pci_bus_type to check whether it is pci device.
> 
> Jan, you OK with this?

Yes, sure - I simply wasn't aware of that wrapper.

Jan

>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>>  drivers/xen/dbgp.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
>> index f3ccc80..8145a59 100644
>> --- a/drivers/xen/dbgp.c
>> +++ b/drivers/xen/dbgp.c
>> @@ -19,7 +19,7 @@ static int xen_dbgp_op(struct usb_hcd *hcd, int op)
>>  	dbgp.op = op;
>>  
>>  #ifdef CONFIG_PCI
>> -	if (ctrlr->bus == &pci_bus_type) {
>> +	if (dev_is_pci(ctrlr)) {
>>  		const struct pci_dev *pdev = to_pci_dev(ctrlr);
>>  
>>  		dbgp.u.pci.seg = pci_domain_nr(pdev->bus);
>> -- 
>> 1.7.1
>> 
>>