mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Namhyung Kim <namhyung@kernel.org>
Subject: [for-next][PATCH 01/17] tracing/uprobes: Fix documentation of uprobe registration syntax
Date: Thu, 02 Jan 2014 21:10:22 -0500	[thread overview]
Message-ID: <20140103021144.510962767@goodmis.org> (raw)
In-Reply-To: <20140103021021.238772653@goodmis.org>

[-- Attachment #1: 0001-tracing-uprobes-Fix-documentation-of-uprobe-registra.patch --]
[-- Type: text/plain, Size: 2274 bytes --]

From: Namhyung Kim <namhyung.kim@lge.com>

The uprobe syntax requires an offset after a file path not a symbol.

Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 Documentation/trace/uprobetracer.txt | 10 +++++-----
 kernel/trace/trace_uprobe.c          |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/trace/uprobetracer.txt b/Documentation/trace/uprobetracer.txt
index d9c3e68..8f1a8b89 100644
--- a/Documentation/trace/uprobetracer.txt
+++ b/Documentation/trace/uprobetracer.txt
@@ -19,15 +19,15 @@ user to calculate the offset of the probepoint in the object.
 
 Synopsis of uprobe_tracer
 -------------------------
-  p[:[GRP/]EVENT] PATH:SYMBOL[+offs] [FETCHARGS] : Set a uprobe
-  r[:[GRP/]EVENT] PATH:SYMBOL[+offs] [FETCHARGS] : Set a return uprobe (uretprobe)
-  -:[GRP/]EVENT                                  : Clear uprobe or uretprobe event
+  p[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS] : Set a uprobe
+  r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS] : Set a return uprobe (uretprobe)
+  -:[GRP/]EVENT                           : Clear uprobe or uretprobe event
 
   GRP           : Group name. If omitted, "uprobes" is the default value.
   EVENT         : Event name. If omitted, the event name is generated based
-                  on SYMBOL+offs.
+                  on PATH+OFFSET.
   PATH          : Path to an executable or a library.
-  SYMBOL[+offs] : Symbol+offset where the probe is inserted.
+  OFFSET        : Offset where the probe is inserted.
 
   FETCHARGS     : Arguments. Each probe can have up to 128 args.
    %REG         : Fetch register REG
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index b6dcc42..c77b92d 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -211,7 +211,7 @@ end:
 
 /*
  * Argument syntax:
- *  - Add uprobe: p|r[:[GRP/]EVENT] PATH:SYMBOL [FETCHARGS]
+ *  - Add uprobe: p|r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS]
  *
  *  - Remove uprobe: -:[GRP/]EVENT
  */
-- 
1.8.4.3



  reply	other threads:[~2014-01-03  2:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-03  2:10 [for-next][PATCH 00/17] tracing/uprobes: Add support for more fetch methods Steven Rostedt
2014-01-03  2:10 ` Steven Rostedt [this message]
2014-01-03  2:10 ` [for-next][PATCH 02/17] tracing/probes: Fix basic print type functions Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 03/17] tracing/kprobes: Factor out struct trace_probe Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 04/17] tracing/uprobes: Convert to " Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 05/17] tracing/kprobes: Move common functions to trace_probe.h Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 06/17] tracing/probes: Integrate duplicate set_print_fmt() Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 07/17] tracing/probes: Move fetch function helpers to trace_probe.h Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 08/17] tracing/probes: Split [ku]probes_fetch_type_table Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 09/17] tracing/probes: Implement stack fetch method for uprobes Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 10/17] tracing/probes: Move symbol fetch method to kprobes Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 11/17] tracing/probes: Add fetch{,_size} member into deref fetch method Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 12/17] tracing/probes: Implement memory fetch method for uprobes Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 13/17] tracing/uprobes: Pass is_return to traceprobe_parse_probe_arg() Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 14/17] tracing/uprobes: Fetch args before reserving a ring buffer Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 15/17] tracing/uprobes: Add support for full argument access methods Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 16/17] uprobes: Allocate ->utask before handler_chain() for tracing handlers Steven Rostedt
2014-01-03  2:10 ` [for-next][PATCH 17/17] tracing/uprobes: Add @+file_offset fetch method Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140103021144.510962767@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=acme@ghostprotocols.net \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=oleg@redhat.com \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome