From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: [for-next][PATCH 16/17] uprobes: Allocate ->utask before handler_chain() for tracing handlers
Date: Thu, 02 Jan 2014 21:10:37 -0500 [thread overview]
Message-ID: <20140103021146.891440418@goodmis.org> (raw)
In-Reply-To: <20140103021021.238772653@goodmis.org>
[-- Attachment #1: 0016-uprobes-Allocate-utask-before-handler_chain-for-trac.patch --]
[-- Type: text/plain, Size: 1241 bytes --]
From: Oleg Nesterov <oleg@redhat.com>
uprobe_trace_print() and uprobe_perf_print() need to pass the additional
info to call_fetch() methods, currently there is no simple way to do this.
current->utask looks like a natural place to hold this info, but we need
to allocate it before handler_chain().
This is a bit unfortunate, perhaps we will find a better solution later,
but this is simple and should work right now.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
kernel/events/uprobes.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 24b7d6c..3cc8e0b 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1828,6 +1828,10 @@ static void handle_swbp(struct pt_regs *regs)
if (unlikely(!test_bit(UPROBE_COPY_INSN, &uprobe->flags)))
goto out;
+ /* Tracing handlers use ->utask to communicate with fetch methods */
+ if (!get_utask())
+ goto out;
+
handler_chain(uprobe, regs);
if (can_skip_sstep(uprobe, regs))
goto out;
--
1.8.4.3
next prev parent reply other threads:[~2014-01-03 2:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 2:10 [for-next][PATCH 00/17] tracing/uprobes: Add support for more fetch methods Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 01/17] tracing/uprobes: Fix documentation of uprobe registration syntax Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 02/17] tracing/probes: Fix basic print type functions Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 03/17] tracing/kprobes: Factor out struct trace_probe Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 04/17] tracing/uprobes: Convert to " Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 05/17] tracing/kprobes: Move common functions to trace_probe.h Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 06/17] tracing/probes: Integrate duplicate set_print_fmt() Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 07/17] tracing/probes: Move fetch function helpers to trace_probe.h Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 08/17] tracing/probes: Split [ku]probes_fetch_type_table Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 09/17] tracing/probes: Implement stack fetch method for uprobes Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 10/17] tracing/probes: Move symbol fetch method to kprobes Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 11/17] tracing/probes: Add fetch{,_size} member into deref fetch method Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 12/17] tracing/probes: Implement memory fetch method for uprobes Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 13/17] tracing/uprobes: Pass is_return to traceprobe_parse_probe_arg() Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 14/17] tracing/uprobes: Fetch args before reserving a ring buffer Steven Rostedt
2014-01-03 2:10 ` [for-next][PATCH 15/17] tracing/uprobes: Add support for full argument access methods Steven Rostedt
2014-01-03 2:10 ` Steven Rostedt [this message]
2014-01-03 2:10 ` [for-next][PATCH 17/17] tracing/uprobes: Add @+file_offset fetch method Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103021146.891440418@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome