From: Mark Brown <broonie@kernel.org>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: lgirdwood@gmail.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl-sai: Add device tree nodes and its availiable check
Date: Fri, 10 Jan 2014 11:09:00 +0000 [thread overview]
Message-ID: <20140110110900.GC29039@sirena.org.uk> (raw)
In-Reply-To: <1389319550-12238-1-git-send-email-Li.Xiubo@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
On Fri, Jan 10, 2014 at 10:05:50AM +0800, Xiubo Li wrote:
> + if (!np || !of_device_is_available(np))
> + return -ENODEV;
> +
I would expect the of_device_is_available() check to be done by the
driver core rather than by individual drivers - every single driver
should have that check. Is this not happening? The check for np is OK
though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-10 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 2:05 Xiubo Li
2014-01-10 11:09 ` Mark Brown [this message]
2014-01-13 6:15 ` Li.Xiubo
2014-01-13 16:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110110900.GC29039@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®