Re: [PATCH] ASoC: fsl-sai: Add device tree nodes and its availiable check

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

On Mon, Jan 13, 2014 at 06:15:24AM +0000, Li.Xiubo@freescale.com wrote:

> > I would expect the of_device_is_available() check to be done by the
> > driver core rather than by individual drivers - every single driver
> > should have that check.  Is this not happening?  The check for np is OK
> > though.

> Yes, I hasn't found the core driver does that for now...

Are you sure, we actively use the ability to mark devices as unavailable
on some systems?

> And IMO this is needed since the SAI driver is only base dts. And maybe
> the device is not presently operational, but it might become operational
> in the future (for example, something is not plugged in, or switched off).
> Or A serious error was detected in the device, and it is unlikely to become
> operational without repair...

I'm sorry but I don't understand what you're saying here at all.  These
are all things that might happen but I don't see the connection between
them and the benefits of implementing things in the core - surely the
more functionality there is the more useful it's going to be to factor
all the code out into the driver core?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]