From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: linux-kernel@vger.kernel.org, Mark Jackson <mpfj@mimc.co.uk>,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Subject: Re: [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h' for MODULE_LICENSE
Date: Sun, 12 Jan 2014 18:16:09 +0100 [thread overview]
Message-ID: <20140112171609.GA3773@samfundet.no> (raw)
In-Reply-To: <1389341774-6589-1-git-send-email-slyfox@gentoo.org>
Around Fri 10 Jan 2014 11:16:14 +0300 or thereabout, Sergei Trofimovich wrote:
> config: make ARCH=avr32 mimc200_defconfig
>
>> All error/warnings:
>>
>> arch/avr32/boards/mimc200/fram.c:79: error: expected declaration specifiers or '...' before string constant
>> arch/avr32/boards/mimc200/fram.c:79: warning: data definition has no type or storage class
>> arch/avr32/boards/mimc200/fram.c:79: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
>> >> arch/avr32/boards/mimc200/fram.c:79: error: function declaration isn't a prototype
>
> Untested.
Looks very sane.
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> CC: Mark Jackson <mpfj@mimc.co.uk>
> CC: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> CC: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> arch/avr32/boards/mimc200/fram.c | 1 +
> 1 file changed, 1 insertion(+)
I will append this to the AVR32 tree at git.kernel.org.
> diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
> index 9764a1a..76cb51d 100644
> --- a/arch/avr32/boards/mimc200/fram.c
> +++ b/arch/avr32/boards/mimc200/fram.c
> @@ -13,6 +13,7 @@
> #include <linux/miscdevice.h>
> #include <linux/proc_fs.h>
> #include <linux/mm.h>
> +#include <linux/module.h>
> #include <linux/io.h>
>
> #define FRAM_BASE 0xac000000
--
mvh
Hans-Christian Egtvedt
prev parent reply other threads:[~2014-01-12 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 8:16 Sergei Trofimovich
2014-01-12 17:16 ` Hans-Christian Egtvedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140112171609.GA3773@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpfj@mimc.co.uk \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome