* [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h' for MODULE_LICENSE
@ 2014-01-10 8:16 Sergei Trofimovich
2014-01-12 17:16 ` Hans-Christian Egtvedt
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Trofimovich @ 2014-01-10 8:16 UTC (permalink / raw)
To: linux-kernel
Cc: Sergei Trofimovich, Mark Jackson, Hans-Christian Egtvedt,
Haavard Skinnemoen
config: make ARCH=avr32 mimc200_defconfig
> All error/warnings:
>
> arch/avr32/boards/mimc200/fram.c:79: error: expected declaration specifiers or '...' before string constant
> arch/avr32/boards/mimc200/fram.c:79: warning: data definition has no type or storage class
> arch/avr32/boards/mimc200/fram.c:79: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> >> arch/avr32/boards/mimc200/fram.c:79: error: function declaration isn't a prototype
Untested.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
CC: Mark Jackson <mpfj@mimc.co.uk>
CC: Hans-Christian Egtvedt <egtvedt@samfundet.no>
CC: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---
arch/avr32/boards/mimc200/fram.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
index 9764a1a..76cb51d 100644
--- a/arch/avr32/boards/mimc200/fram.c
+++ b/arch/avr32/boards/mimc200/fram.c
@@ -13,6 +13,7 @@
#include <linux/miscdevice.h>
#include <linux/proc_fs.h>
#include <linux/mm.h>
+#include <linux/module.h>
#include <linux/io.h>
#define FRAM_BASE 0xac000000
--
1.8.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h' for MODULE_LICENSE
2014-01-10 8:16 [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h' for MODULE_LICENSE Sergei Trofimovich
@ 2014-01-12 17:16 ` Hans-Christian Egtvedt
0 siblings, 0 replies; 2+ messages in thread
From: Hans-Christian Egtvedt @ 2014-01-12 17:16 UTC (permalink / raw)
To: Sergei Trofimovich; +Cc: linux-kernel, Mark Jackson, Haavard Skinnemoen
Around Fri 10 Jan 2014 11:16:14 +0300 or thereabout, Sergei Trofimovich wrote:
> config: make ARCH=avr32 mimc200_defconfig
>
>> All error/warnings:
>>
>> arch/avr32/boards/mimc200/fram.c:79: error: expected declaration specifiers or '...' before string constant
>> arch/avr32/boards/mimc200/fram.c:79: warning: data definition has no type or storage class
>> arch/avr32/boards/mimc200/fram.c:79: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
>> >> arch/avr32/boards/mimc200/fram.c:79: error: function declaration isn't a prototype
>
> Untested.
Looks very sane.
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> CC: Mark Jackson <mpfj@mimc.co.uk>
> CC: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> CC: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> arch/avr32/boards/mimc200/fram.c | 1 +
> 1 file changed, 1 insertion(+)
I will append this to the AVR32 tree at git.kernel.org.
> diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
> index 9764a1a..76cb51d 100644
> --- a/arch/avr32/boards/mimc200/fram.c
> +++ b/arch/avr32/boards/mimc200/fram.c
> @@ -13,6 +13,7 @@
> #include <linux/miscdevice.h>
> #include <linux/proc_fs.h>
> #include <linux/mm.h>
> +#include <linux/module.h>
> #include <linux/io.h>
>
> #define FRAM_BASE 0xac000000
--
mvh
Hans-Christian Egtvedt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-12 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-10 8:16 [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h' for MODULE_LICENSE Sergei Trofimovich
2014-01-12 17:16 ` Hans-Christian Egtvedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome