mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: boris brezillon <b.brezillon@overkiz.com>
Cc: Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	nicolas.ferre@atmel.com, arnd@arndb.de,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 03/12] at91: dt: sam9261: Added support for the lcd display
Date: Wed, 15 Jan 2014 12:27:29 +0100	[thread overview]
Message-ID: <20140115112729.GS14627@ns203013.ovh.net> (raw)
In-Reply-To: <52CED74B.3030806@overkiz.com>

On 18:07 Thu 09 Jan     , boris brezillon wrote:
> On 09/01/2014 13:31, Jean-Jacques Hiblot wrote:
> >Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> >---
> >  arch/arm/boot/dts/at91sam9261.dtsi  | 37 ++++++++++++++++++++++++++++++++++++-
> >  arch/arm/boot/dts/at91sam9261ek.dts | 31 +++++++++++++++++++++++++++++++
> >  arch/arm/mach-at91/at91sam9261.c    |  1 +
> >  3 files changed, 68 insertions(+), 1 deletion(-)
> >
> >diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
> >index 773c3d6..cd219b9 100644
> >--- a/arch/arm/boot/dts/at91sam9261.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9261.dtsi
> >@@ -290,7 +290,33 @@
> >  						atmel,pins = <AT91_PIOC 24 AT91_PERIPH_B AT91_PINCTRL_NONE>;
> >  					};
> >  				};
> >-
> >+				fb {
> >+					pinctrl_fb: fb-0 {
> >+						atmel,pins =
> >+							<AT91_PIOB 1 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB1 periph A */
> >+							 AT91_PIOB 2 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB2 periph A */
> >+							 AT91_PIOB 3 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB3 periph A */
> >+							 AT91_PIOB 7 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB7 periph A */
> >+							 AT91_PIOB 8 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB8 periph A */
> >+							 AT91_PIOB 9 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB9 periph A */
> >+							 AT91_PIOB 10 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB10 periph A */
> >+							 AT91_PIOB 11 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB11 periph A */
> >+							 AT91_PIOB 12 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB12 periph A */
> >+							 AT91_PIOB 15 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB15 periph A */
> >+							 AT91_PIOB 16 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB16 periph A */
> >+							 AT91_PIOB 17 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB17 periph A */
> >+							 AT91_PIOB 18 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB18 periph A */
> >+							 AT91_PIOB 19 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB19 periph A */
> >+							 AT91_PIOB 20 AT91_PERIPH_A AT91_PINCTRL_NONE	/* PB20 periph A */
> >+							 AT91_PIOB 23 AT91_PERIPH_B AT91_PINCTRL_NONE	/* PB23 periph B */
> >+							 AT91_PIOB 24 AT91_PERIPH_B AT91_PINCTRL_NONE	/* PB24 periph B */
> >+							 AT91_PIOB 25 AT91_PERIPH_B AT91_PINCTRL_NONE	/* PB25 periph B */
> >+							 AT91_PIOB 26 AT91_PERIPH_B AT91_PINCTRL_NONE	/* PB26 periph B */
> >+							 AT91_PIOB 27 AT91_PERIPH_B AT91_PINCTRL_NONE	/* PB27 periph B */
> >+							 AT91_PIOB 28 AT91_PERIPH_B AT91_PINCTRL_NONE	/* PB28 periph B */
> >+							 >;
> >+					};
> >+				};
> >  				pioA: gpio@fffff400 {
> >  					compatible = "atmel,at91rm9200-gpio";
> >  					reg = <0xfffff400 0x200>;
> >@@ -436,6 +462,15 @@
> >  			};
> >  		};
> >+		fb0: fb@0x00600000 {
> >+			compatible = "atmel,at91sam9261-lcdc";
> >+			reg = <0x00600000 0x1000>;
> >+			interrupts = <21 IRQ_TYPE_LEVEL_HIGH 3>;
> >+			pinctrl-names = "default";
> >+			pinctrl-0 = <&pinctrl_fb>;
> >+			status = "disabled";
> >+		};
> >+
> >  		nand0: nand@40000000 {
> >  			compatible = "atmel,at91rm9200-nand";
> >  			#address-cells = <1>;
> >diff --git a/arch/arm/boot/dts/at91sam9261ek.dts b/arch/arm/boot/dts/at91sam9261ek.dts
> >index f3d22a9..03c05fc 100644
> >--- a/arch/arm/boot/dts/at91sam9261ek.dts
> >+++ b/arch/arm/boot/dts/at91sam9261ek.dts
> >@@ -52,6 +52,37 @@
> >  				reg = <0x0 0x20000>;
> >  			};
> >  		};
> 
> One more nitpick :
> I think this should be taken out in another patch (first 9261 lcdc support,
> then ek board lcd def) :p.

yes mandatory

Best Regards,
J.
> 
> >+
> >+		fb0: fb@0x00600000 {
> >+			display = <&display0>;
> >+			status = "okay";
> >+			atmel,power-control-gpio = <&pioA 12 GPIO_ACTIVE_LOW>;
> >+			display0: display {
> >+				bits-per-pixel = <16>;
> >+				atmel,lcdcon-backlight;
> >+				atmel,dmacon = <0x1>;
> >+				atmel,lcdcon2 = <0x80008002>;
> >+				atmel,guard-time = <1>;
> >+				atmel,lcd-wiring-mode = "BRG";
> >+
> >+				display-timings {
> >+					native-mode = <&timing0>;
> >+					timing0: timing0 {
> >+						clock-frequency = <4965000>;
> >+						hactive = <240>;
> >+						vactive = <320>;
> >+						hback-porch = <1>;
> >+						hfront-porch = <33>;
> >+						vback-porch = <1>;
> >+						vfront-porch = <0>;
> >+						hsync-len = <5>;
> >+						vsync-len = <1>;
> >+						hsync-active = <1>;
> >+						vsync-active = <1>;
> >+					};
> >+				};
> >+			};
> >+		};
> >  	};
> >  	leds {
> >diff --git a/arch/arm/mach-at91/at91sam9261.c b/arch/arm/mach-at91/at91sam9261.c
> >index 200d17a..a67bfe6 100644
> >--- a/arch/arm/mach-at91/at91sam9261.c
> >+++ b/arch/arm/mach-at91/at91sam9261.c
> >@@ -197,6 +197,7 @@ static struct clk_lookup periph_clocks_lookups[] = {
> >  	/* more tc lookup table for DT entries */
> >  	CLKDEV_CON_DEV_ID("t0_clk", "fffa0000.timer", &tc0_clk),
> >  	CLKDEV_CON_DEV_ID("hclk", "500000.ohci", &ohci_clk),
> >+	CLKDEV_CON_DEV_ID("hclk", "600000.fb", &hck1),
> >  	CLKDEV_CON_DEV_ID("spi_clk", "fffc8000.spi", &spi0_clk),
> >  	CLKDEV_CON_DEV_ID("spi_clk", "fffcc000.spi", &spi1_clk),
> >  	CLKDEV_CON_DEV_ID("mci_clk", "fffa8000.mmc", &mmc_clk),
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2014-01-15 11:26 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 12:31 [PATCH v2 00/12] Device Tree support for the at91sam9261ek Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 01/12] at91: dt: Add at91sam9261 dt SoC support Jean-Jacques Hiblot
2014-01-14 17:01   ` Nicolas Ferre
2014-01-15 10:08     ` Jean-Jacques Hiblot
2014-01-15 10:14       ` Nicolas Ferre
2014-01-15 11:31     ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-09 12:31 ` [PATCH v2 02/12] at91: dt: sam9261: Basic Device Tree support for the at91sam9261ek Jean-Jacques Hiblot
2014-01-14 17:06   ` Nicolas Ferre
2014-01-09 12:31 ` [PATCH v2 03/12] at91: dt: sam9261: Added support for the lcd display Jean-Jacques Hiblot
2014-01-09 17:07   ` boris brezillon
2014-01-15 11:27     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2014-01-14 17:09   ` Nicolas Ferre
2014-01-09 12:31 ` [PATCH v2 04/12] at91: smc: export sam9_smc_cs_read and sam9_smc_cs_configure Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 05/12] at91: smc: Increased the size of tdf_cycles in struct sam9_smc_config Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 06/12] at91: smc: Adds helper functions to validate and clip the smc timings Jean-Jacques Hiblot
2014-01-15  9:44   ` Nicolas Ferre
2014-01-15  9:54     ` Jean-Jacques Hiblot
2014-01-15 10:18       ` Nicolas Ferre
2014-01-09 12:31 ` [PATCH v2 07/12] at91: dt: smc: Added smc bus driver Jean-Jacques Hiblot
2014-01-09 16:59   ` boris brezillon
2014-01-09 21:04     ` Jean-Jacques Hiblot
2014-01-10 11:01       ` Jean-Jacques Hiblot
2014-01-10 11:08         ` Jean-Jacques Hiblot
2014-01-11  8:06       ` boris brezillon
2014-01-14 14:20         ` Jean-Jacques Hiblot
2014-01-14 15:01           ` Nicolas Ferre
2014-02-07  8:42   ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-09 12:31 ` [PATCH v2 08/12] at91: sam9261: Add a clock definition for the smc Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 09/12] at91: dt: sam9261: Pinmux DT entries for the SMC/EBI interface Jean-Jacques Hiblot
2014-01-15 11:25   ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-09 12:31 ` [PATCH v2 10/12] at91: dt: sam9261: Add an entry in the DT for the SMC/EBI bus driver Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 11/12] at91: dt: sam9261: moved the NAND under the smc node Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 12/12] at91: dt: sam9261: Added DM9000 in the device tree Jean-Jacques Hiblot
2014-01-15 11:23   ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-14 16:54 ` [PATCH v2 00/12] Device Tree support for the at91sam9261ek Nicolas Ferre
2014-01-15  8:34   ` Jean-Jacques Hiblot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140115112729.GS14627@ns203013.ovh.net \
    --to=plagnioj@jcrosoft.com \
    --cc=arnd@arndb.de \
    --cc=b.brezillon@overkiz.com \
    --cc=jjhiblot@traphandler.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®