[PATCHv2] dt: binding documentation for bq2415x charger

[PATCHv2] dt: binding documentation for bq2415x charger

[Sebastian Reichel]

Add devicetree binding documentation for bq2415x charger.

Signed-off-by: Sebastian Reichel <sre@debian.org>
---
Hi,

This is the second version of the bq2415x binding documentation. The
only changes since PATCHv1 are a rewording of the property descriptions
as requested by Pavel Machek.

I narrowed down the CCs for this patch, since there were no comments on
PATCHv1 from omap or DT binding guys and Anton has applied the driver changes
already. This patch is intended for 3.14, so that it gets merged together
with the driver changes.

-- Sebastian
---
 .../devicetree/bindings/power/bq2415x.txt          | 48 ++++++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/bq2415x.txt

diff --git a/Documentation/devicetree/bindings/power/bq2415x.txt b/Documentation/devicetree/bindings/power/bq2415x.txt
new file mode 100644
index 0000000..64f4a7f
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/bq2415x.txt
@@ -0,0 +1,48 @@
+Binding for TI bq2415x Li-Ion Charger
+
+Required properties:
+- compatible: Should contain one of the following:
+ * "ti,bq24150"
+ * "ti,bq24150"
+ * "ti,bq24150a"
+ * "ti,bq24151"
+ * "ti,bq24151a"
+ * "ti,bq24152"
+ * "ti,bq24153"
+ * "ti,bq24153a"
+ * "ti,bq24155"
+ * "ti,bq24156"
+ * "ti,bq24156a"
+ * "ti,bq24158"
+- reg:			   integer, i2c address of the device.
+- ti,current-limit:	   integer, initial maximum current charger can pull
+			   from power supply in mA.
+- ti,weak-battery-voltage: integer, weak battery voltage threshold in mV.
+			   The chip will use slow precharge if battery voltage
+			   is below this value.
+- ti,battery-regulation-voltage: integer, maximum charging voltage in mV.
+- ti,charge-current:	   integer, maximum charging current in mA.
+- ti,termination-current:  integer, charge will be terminated when current in
+			   constant-voltage phase drops below this value (in
+			   mA), charge is terminated.
+- ti,resistor-sense:	   integer, value of sensing resistor in milliohm.
+
+Optional properties:
+- ti,usb-charger-detection: phandle to usb charger detection device.
+			    (required for auto mode)
+
+Example from Nokia N900:
+
+bq24150a {
+	compatible = "ti,bq24150a";
+	reg = <0x6b>;
+
+	ti,current-limit = <100>;
+	ti,weak-battery-voltage = <3400>;
+	ti,battery-regulation-voltage = <4200>;
+	ti,charge-current = <650>;
+	ti,termination-current = <100>;
+	ti,resistor-sense = <68>;
+
+	ti,usb-charger-detection = <&isp1704>;
+};
-- 
1.8.5.2

[PATCHv3] dt: binding documentation for bq2415x charger

[Sebastian Reichel]

Add devicetree binding documentation for bq2415x charger.

Signed-off-by: Sebastian Reichel <sre@debian.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
Hi,

It's me again :) Here's another update, which fixes a sentence reported by
Pavel. I also added his Acked-by.

-- Sebastian
---
 .../devicetree/bindings/power/bq2415x.txt          | 47 ++++++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/bq2415x.txt

diff --git a/Documentation/devicetree/bindings/power/bq2415x.txt b/Documentation/devicetree/bindings/power/bq2415x.txt
new file mode 100644
index 0000000..d0327f0
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/bq2415x.txt
@@ -0,0 +1,47 @@
+Binding for TI bq2415x Li-Ion Charger
+
+Required properties:
+- compatible: Should contain one of the following:
+ * "ti,bq24150"
+ * "ti,bq24150"
+ * "ti,bq24150a"
+ * "ti,bq24151"
+ * "ti,bq24151a"
+ * "ti,bq24152"
+ * "ti,bq24153"
+ * "ti,bq24153a"
+ * "ti,bq24155"
+ * "ti,bq24156"
+ * "ti,bq24156a"
+ * "ti,bq24158"
+- reg:			   integer, i2c address of the device.
+- ti,current-limit:	   integer, initial maximum current charger can pull
+			   from power supply in mA.
+- ti,weak-battery-voltage: integer, weak battery voltage threshold in mV.
+			   The chip will use slow precharge if battery voltage
+			   is below this value.
+- ti,battery-regulation-voltage: integer, maximum charging voltage in mV.
+- ti,charge-current:	   integer, maximum charging current in mA.
+- ti,termination-current:  integer, charge will be terminated when current in
+			   constant-voltage phase drops below this value (in mA).
+- ti,resistor-sense:	   integer, value of sensing resistor in milliohm.
+
+Optional properties:
+- ti,usb-charger-detection: phandle to usb charger detection device.
+			    (required for auto mode)
+
+Example from Nokia N900:
+
+bq24150a {
+	compatible = "ti,bq24150a";
+	reg = <0x6b>;
+
+	ti,current-limit = <100>;
+	ti,weak-battery-voltage = <3400>;
+	ti,battery-regulation-voltage = <4200>;
+	ti,charge-current = <650>;
+	ti,termination-current = <100>;
+	ti,resistor-sense = <68>;
+
+	ti,usb-charger-detection = <&isp1704>;
+};
-- 
1.8.5.2

Re: [PATCHv3] dt: binding documentation for bq2415x charger

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi Dmitry,

> Add devicetree binding documentation for bq2415x charger.
> 
> Signed-off-by: Sebastian Reichel <sre@debian.org>
> Acked-by: Pavel Machek <pavel@ucw.cz>

I've seen, that you just sent a pull request for the power supply
tree. Can you please add this patch [0] and send another pull
request? It should go into the kernel together with the bq2415x DT
support patch!

[0] http://www.spinics.net/lists/devicetree/msg18023.html

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCHv3] dt: binding documentation for bq2415x charger

[Dmitry Eremin-Solenikov]

Hello,

On Wed, Jan 22, 2014 at 12:48 AM, Sebastian Reichel <sre@ring0.de> wrote:
> Hi Dmitry,
>
>> Add devicetree binding documentation for bq2415x charger.
>>
>> Signed-off-by: Sebastian Reichel <sre@debian.org>
>> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> I've seen, that you just sent a pull request for the power supply
> tree. Can you please add this patch [0] and send another pull
> request? It should go into the kernel together with the bq2415x DT
> support patch!

If that is fine with you, I will add this to a 'fixes' branch and send
a pull request
somewhere near -rc2/-rc3. Agreed?

>
> [0] http://www.spinics.net/lists/devicetree/msg18023.html

-- 
With best wishes
Dmitry

Re: [PATCHv3] dt: binding documentation for bq2415x charger

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

On Wed, Jan 22, 2014 at 04:07:25PM +0400, Dmitry Eremin-Solenikov wrote:
> On Wed, Jan 22, 2014 at 12:48 AM, Sebastian Reichel <sre@ring0.de> wrote:
> >> Add devicetree binding documentation for bq2415x charger.
> >> [...]
> >
> > I've seen, that you just sent a pull request for the power supply
> > tree. Can you please add this patch [0] and send another pull
> > request? It should go into the kernel together with the bq2415x DT
> > support patch!
> 
> If that is fine with you, I will add this to a 'fixes' branch and
> send a pull request somewhere near -rc2/-rc3. Agreed?

Sounds fine to me.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]