From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: anton@enomsg.org, dwmw2@infradead.org, grant.likely@linaro.org,
robh+dt@kernel.org, yongjun_wei@trendmicro.com.cn,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] isp1704_charger: remove useless check in isp1704_charger_probe()
Date: Sat, 25 Jan 2014 15:22:24 +0400 [thread overview]
Message-ID: <20140125112224.GB2435@anuminas.rup.mentorg.com> (raw)
In-Reply-To: <CAPgLHd_XJqAjhdv=J8d9TwdchS203_GqUTvRYM9SAS12roiYBA@mail.gmail.com>
On Tue, Jan 07, 2014 at 09:12:29PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Neither devm_usb_get_phy_by_phandle() nor devm_usb_get_phy() can
> return a NULL result, so remove the useless !isp->phy check.
Thank you, applying.
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/power/isp1704_charger.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
> index 80edb7d..0b4cf9d 100644
> --- a/drivers/power/isp1704_charger.c
> +++ b/drivers/power/isp1704_charger.c
> @@ -444,8 +444,6 @@ static int isp1704_charger_probe(struct platform_device *pdev)
> ret = PTR_ERR(isp->phy);
> goto fail0;
> }
> - if (!isp->phy)
> - goto fail0;
>
> isp->dev = &pdev->dev;
> platform_set_drvdata(pdev, isp);
prev parent reply other threads:[~2014-01-25 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 13:12 Wei Yongjun
2014-01-25 11:22 ` Dmitry Eremin-Solenikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140125112224.GB2435@anuminas.rup.mentorg.com \
--to=dbaryshkov@gmail.com \
--cc=anton@enomsg.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®