* [PATCH -next] isp1704_charger: remove useless check in isp1704_charger_probe()
@ 2014-01-07 13:12 Wei Yongjun
2014-01-25 11:22 ` Dmitry Eremin-Solenikov
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2014-01-07 13:12 UTC (permalink / raw)
To: anton, dwmw2, grant.likely, robh+dt; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Neither devm_usb_get_phy_by_phandle() nor devm_usb_get_phy() can
return a NULL result, so remove the useless !isp->phy check.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/power/isp1704_charger.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
index 80edb7d..0b4cf9d 100644
--- a/drivers/power/isp1704_charger.c
+++ b/drivers/power/isp1704_charger.c
@@ -444,8 +444,6 @@ static int isp1704_charger_probe(struct platform_device *pdev)
ret = PTR_ERR(isp->phy);
goto fail0;
}
- if (!isp->phy)
- goto fail0;
isp->dev = &pdev->dev;
platform_set_drvdata(pdev, isp);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] isp1704_charger: remove useless check in isp1704_charger_probe()
2014-01-07 13:12 [PATCH -next] isp1704_charger: remove useless check in isp1704_charger_probe() Wei Yongjun
@ 2014-01-25 11:22 ` Dmitry Eremin-Solenikov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Eremin-Solenikov @ 2014-01-25 11:22 UTC (permalink / raw)
To: Wei Yongjun
Cc: anton, dwmw2, grant.likely, robh+dt, yongjun_wei, linux-kernel
On Tue, Jan 07, 2014 at 09:12:29PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Neither devm_usb_get_phy_by_phandle() nor devm_usb_get_phy() can
> return a NULL result, so remove the useless !isp->phy check.
Thank you, applying.
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/power/isp1704_charger.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
> index 80edb7d..0b4cf9d 100644
> --- a/drivers/power/isp1704_charger.c
> +++ b/drivers/power/isp1704_charger.c
> @@ -444,8 +444,6 @@ static int isp1704_charger_probe(struct platform_device *pdev)
> ret = PTR_ERR(isp->phy);
> goto fail0;
> }
> - if (!isp->phy)
> - goto fail0;
>
> isp->dev = &pdev->dev;
> platform_set_drvdata(pdev, isp);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-25 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-07 13:12 [PATCH -next] isp1704_charger: remove useless check in isp1704_charger_probe() Wei Yongjun
2014-01-25 11:22 ` Dmitry Eremin-Solenikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®