* [PATCH] afs: proc cells and rootcell are writeable [ver #2]
@ 2014-01-28 20:26 David Howells
0 siblings, 0 replies; only message in thread
From: David Howells @ 2014-01-28 20:26 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, linux-afs, Pali Rohár
From: Pali Rohár <pali.rohar@gmail.com>
Both proc files are writeable and used for configuring cells. But
there is missing correct mode flag for writeable files. Without
this patch both proc files are read only.
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/afs/proc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/afs/proc.c b/fs/afs/proc.c
index 526e4bbbde59..2d9279fcf25e 100644
--- a/fs/afs/proc.c
+++ b/fs/afs/proc.c
@@ -147,11 +147,11 @@ int afs_proc_init(void)
if (!proc_afs)
goto error_dir;
- p = proc_create("cells", 0, proc_afs, &afs_proc_cells_fops);
+ p = proc_create("cells", 0644, proc_afs, &afs_proc_cells_fops);
if (!p)
goto error_cells;
- p = proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops);
+ p = proc_create("rootcell", 0644, proc_afs, &afs_proc_rootcell_fops);
if (!p)
goto error_rootcell;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-01-28 20:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-28 20:26 [PATCH] afs: proc cells and rootcell are writeable [ver #2] David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®