From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Will Deacon <will.deacon@arm.com>
Cc: Fabrice GASNIER <fabrice.gasnier@st.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
Jonathan Austin <Jonathan.Austin@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"nico@linaro.org" <nico@linaro.org>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
Marc Zyngier <Marc.Zyngier@arm.com>,
"ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>,
"vgupta@synopsys.com" <vgupta@synopsys.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"maxime.coquelin@st.com" <maxime.coquelin@st.com>
Subject: Re: [RFC PATCH] ARM: Add imprecise abort enable/disable macro
Date: Mon, 10 Feb 2014 13:58:45 +0000 [thread overview]
Message-ID: <20140210135845.GV26684@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140207170903.GT5976@mudshark.cambridge.arm.com>
On Fri, Feb 07, 2014 at 05:09:03PM +0000, Will Deacon wrote:
> On Fri, Feb 07, 2014 at 04:19:15PM +0000, Fabrice GASNIER wrote:
> > +#define local_abt_enable() \
> > + ({ \
> > + unsigned long temp; \
> > + __asm__ __volatile__( \
> > + "mrs %0, cpsr @ sta\n" \
> > +" bic %0, %0, %1\n" \
> > +" msr cpsr_c, %0" \
> > + : "=r" (temp) \
> > + : "r" (PSR_A_BIT) \
>
> Can you use "i" instead of a register for this constant?
As the PSR A bit isn't in bits 7-0, cpsr_c isn't what's required here.
It needs something different... that's why my previous patch for you
didn't work.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
next prev parent reply other threads:[~2014-02-10 13:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 16:19 [RFC PATCH] ARM: Enable imprecise external aborts earlier Fabrice GASNIER
2014-02-07 16:19 ` [RFC PATCH] ARM: Add imprecise abort enable/disable macro Fabrice GASNIER
2014-02-07 17:09 ` Will Deacon
2014-02-10 8:50 ` Fabrice Gasnier
2014-02-10 9:00 ` Ben Dooks
2014-02-10 13:32 ` Fabrice Gasnier
2014-02-10 11:17 ` Will Deacon
2014-02-10 13:54 ` Fabrice Gasnier
2014-02-10 13:56 ` Russell King - ARM Linux
2014-02-10 14:12 ` Will Deacon
2014-02-10 14:42 ` Dave Martin
2014-02-10 15:19 ` Russell King - ARM Linux
2014-02-10 16:28 ` Dave Martin
2014-02-10 16:37 ` Russell King - ARM Linux
2014-02-10 17:28 ` Dave Martin
2014-02-10 13:58 ` Russell King - ARM Linux [this message]
2014-02-10 14:16 ` Dave Martin
2014-02-10 14:44 ` Fabrice Gasnier
2014-02-10 15:12 ` Dave Martin
2014-02-10 15:24 ` Russell King - ARM Linux
2014-02-10 16:36 ` Fabrice Gasnier
2014-02-10 14:54 ` Ben Dooks
2014-02-10 15:21 ` Dave Martin
2014-02-10 16:38 ` Ben Dooks
2014-02-11 15:38 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210135845.GV26684@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Catalin.Marinas@arm.com \
--cc=Jonathan.Austin@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=ben.dooks@codethink.co.uk \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=nico@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vgupta@synopsys.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®