* Re: [PATCH 1/2] scsi_sysfs: Implement 'is_visible' callback
[not found] ` <1392129294-55235-2-git-send-email-hare@suse.de>
@ 2014-02-12 7:57 ` Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2014-02-12 7:57 UTC (permalink / raw)
To: Hannes Reinecke
Cc: James Bottomley, Greg Kroah-Hartman, linux-scsi, linux-kernel
On Tue, Feb 11, 2014 at 03:34:53PM +0100, Hannes Reinecke wrote:
> Instead of modifying attributes after the device has been created
> we should be using the 'is_visible' callback to avoid races.
Can't say I like the fact that the is_visible function needs is
per-group and not per attribute and thus needs to explicitly check
which attribute we call it for, but that seems to be a design issue in
the driver core and not the patch.
Otherwise looks good with the minor nitpick that it would have looked
cleaner in the patch if you had left the queue_type store function
in the location it previously was.
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-02-12 7:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1392129294-55235-1-git-send-email-hare@suse.de>
[not found] ` <1392129294-55235-2-git-send-email-hare@suse.de>
2014-02-12 7:57 ` [PATCH 1/2] scsi_sysfs: Implement 'is_visible' callback Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®