* [PATCH v2] ata: libahci: make ahci_pmp_retry_softreset() as static
@ 2014-02-19 23:34 Daeseok Youn
2014-02-20 0:09 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Daeseok Youn @ 2014-02-19 23:34 UTC (permalink / raw)
To: davem, tj; +Cc: sergei.shtylyov, linux-ide, linux-kernel
>From 6f865fde2e48ddc09f940ec30ebfc144cf074fd1 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Wed, 19 Feb 2014 10:56:37 +0900
Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static
sparse says:
drivers/ata/libahci.c:1390:5: warning:
symbol 'ahci_pmp_retry_softreset' was not declared. Should it be static?
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/ata/libahci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 36605ab..4789950 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1387,8 +1387,8 @@ static int ahci_bad_pmp_check_ready(struct ata_link *link)
return ata_check_ready(status);
}
-int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class,
- unsigned long deadline)
+static int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class,
+ unsigned long deadline)
{
struct ata_port *ap = link->ap;
void __iomem *port_mmio = ahci_port_base(ap);
--
1.7.9.5
---
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ata: libahci: make ahci_pmp_retry_softreset() as static
2014-02-19 23:34 [PATCH v2] ata: libahci: make ahci_pmp_retry_softreset() as static Daeseok Youn
@ 2014-02-20 0:09 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2014-02-20 0:09 UTC (permalink / raw)
To: Daeseok Youn; +Cc: davem, sergei.shtylyov, linux-ide, linux-kernel
On Thu, Feb 20, 2014 at 08:34:27AM +0900, Daeseok Youn wrote:
> From 6f865fde2e48ddc09f940ec30ebfc144cf074fd1 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Wed, 19 Feb 2014 10:56:37 +0900
> Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static
>
> sparse says:
>
> drivers/ata/libahci.c:1390:5: warning:
> symbol 'ahci_pmp_retry_softreset' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Applied to libata/for-3.15.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-20 0:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-19 23:34 [PATCH v2] ata: libahci: make ahci_pmp_retry_softreset() as static Daeseok Youn
2014-02-20 0:09 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®