From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 5/8] perf diff: Add --percentage option
Date: Thu, 20 Feb 2014 11:49:17 +0100 [thread overview]
Message-ID: <20140220104917.GD11018@krava.brq.redhat.com> (raw)
In-Reply-To: <1392000446-14744-6-git-send-email-namhyung@kernel.org>
On Mon, Feb 10, 2014 at 11:47:22AM +0900, Namhyung Kim wrote:
> The --percentage option is for controlling overhead percentage
> displayed. It can only receive either of "relative" or "absolute" and
> affects -c delta output only.
>
> For more information, please see previous commit same thing done to
> "perf report".
>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/Documentation/perf-diff.txt | 21 +++++++++++++---
> tools/perf/builtin-diff.c | 46 +++++++++++++++++++++++++++++-----
> 2 files changed, 58 insertions(+), 9 deletions(-)
SNIP
> @@ -259,11 +263,18 @@ static s64 compute_wdiff(struct hist_entry *he, struct hist_entry *pair)
> static int formula_delta(struct hist_entry *he, struct hist_entry *pair,
> char *buf, size_t size)
> {
> + u64 he_total = he->hists->stats.total_period;
> + u64 pair_total = pair->hists->stats.total_period;
> +
> + if (symbol_conf.filter_relative) {
> + he_total = he->hists->stats.total_filtered_period;
> + pair_total = pair->hists->stats.total_filtered_period;
> + }
and another ;-)
jirka
next prev parent reply other threads:[~2014-02-20 10:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 2:47 [PATCHSET 0/8] perf tools: Update on filtered entries' percentage output (v4) Namhyung Kim
2014-02-10 2:47 ` [PATCH 1/8] perf tools: Count periods of filtered entries separately Namhyung Kim
2014-02-10 2:47 ` [PATCH 2/8] perf hists: Add support for showing relative percentage Namhyung Kim
2014-02-10 2:47 ` [PATCH 3/8] perf report: Add --percentage option Namhyung Kim
2014-02-20 10:39 ` Jiri Olsa
2014-02-24 6:37 ` Namhyung Kim
2014-02-10 2:47 ` [PATCH 4/8] perf top: " Namhyung Kim
2014-02-20 10:44 ` Jiri Olsa
2014-02-24 6:37 ` Namhyung Kim
2014-02-10 2:47 ` [PATCH 5/8] perf diff: " Namhyung Kim
2014-02-20 10:47 ` Jiri Olsa
2014-02-20 10:49 ` Jiri Olsa [this message]
2014-02-10 2:47 ` [PATCH 6/8] perf tools: Add hist.percentage config option Namhyung Kim
2014-02-20 11:01 ` Jiri Olsa
2014-02-24 6:41 ` Namhyung Kim
2014-02-10 2:47 ` [PATCH 7/7] perf tools: Show absolute percentage by default Namhyung Kim
2014-02-10 3:00 ` Namhyung Kim
2014-02-10 2:47 ` [PATCH 7/8] perf ui/tui: Add 'F' hotkey to toggle percentage output Namhyung Kim
2014-02-20 10:54 ` Jiri Olsa
2014-02-24 7:49 ` Namhyung Kim
2014-02-10 2:47 ` [PATCH 8/8] perf tools: Show absolute percentage by default Namhyung Kim
2014-02-20 1:00 ` [PATCHSET 0/8] perf tools: Update on filtered entries' percentage output (v4) Namhyung Kim
2014-02-24 8:09 [PATCHSET 0/8] perf tools: Update on filtered entries' percentage output (v5) Namhyung Kim
2014-02-24 8:09 ` [PATCH 5/8] perf diff: Add --percentage option Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220104917.GD11018@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome