From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Ian Abbott <ian.abbott@mev.co.uk>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Monam Agarwal <monamagarwal123@gmail.com>
Subject: Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
Date: Tue, 25 Feb 2014 14:05:32 +0300 [thread overview]
Message-ID: <20140225110532.GK26722@mwanda> (raw)
In-Reply-To: <1393322365.8716.3.camel@joe-AO722>
On Tue, Feb 25, 2014 at 01:59:25AM -0800, Joe Perches wrote:
> On Tue, 2014-02-25 at 09:46 +0000, Ian Abbott wrote:
> > On 2014-02-24 16:49, Monam Agarwal wrote:
> []
> > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> []
> > > @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev,
> > > async->cmd.data = NULL;
> > > /* load channel/gain list */
> > > async->cmd.chanlist = memdup_user(user_chanlist,
> > > - async->cmd.chanlist_len * sizeof(int));
> > > + async->cmd.chanlist_len
> > > + * sizeof(int));
> >
> > The `*` operator should go at the end of the line according to the
> > CodingStyle.
>
> I don't believe there's a CodingStyle guide for this.
>
Meanwhile you have felt totally justified in correcting me on this in
the past. :P
Anyway, it should be that the operator goes on the first line like Ian
says...
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-25 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 16:49 Monam Agarwal
2014-02-25 9:46 ` Ian Abbott
2014-02-25 9:59 ` Joe Perches
2014-02-25 11:05 ` Dan Carpenter [this message]
2014-02-25 11:48 ` Joe Perches
2014-02-25 14:36 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225110532.GK26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ian.abbott@mev.co.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome