From: Ian Abbott <abbotti@mev.co.uk>
To: Monam Agarwal <monamagarwal123@gmail.com>,
Ian Abbott <ian.abbott@mev.co.uk>,
"hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
Date: Tue, 25 Feb 2014 09:46:19 +0000 [thread overview]
Message-ID: <530C666B.6080900@mev.co.uk> (raw)
In-Reply-To: <1393260582-10234-1-git-send-email-monamagarwal123@gmail.com>
On 2014-02-24 16:49, Monam Agarwal wrote:
> Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index ac1edd9..7da8566 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev,
> async->cmd.data = NULL;
> /* load channel/gain list */
> async->cmd.chanlist = memdup_user(user_chanlist,
> - async->cmd.chanlist_len * sizeof(int));
> + async->cmd.chanlist_len
> + * sizeof(int));
The `*` operator should go at the end of the line according to the
CodingStyle.
> if (IS_ERR(async->cmd.chanlist)) {
> ret = PTR_ERR(async->cmd.chanlist);
> async->cmd.chanlist = NULL;
>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2014-02-25 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 16:49 Monam Agarwal
2014-02-25 9:46 ` Ian Abbott [this message]
2014-02-25 9:59 ` Joe Perches
2014-02-25 11:05 ` Dan Carpenter
2014-02-25 11:48 ` Joe Perches
2014-02-25 14:36 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530C666B.6080900@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome