From: Felipe Balbi <balbi@ti.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Robert Baldyga <r.baldyga@samsung.com>,
Felipe Balbi <balbi@ti.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Chuansheng Liu <chuansheng.liu@intel.com>,
<gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <david.a.cohen@linux.intel.com>
Subject: Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile_io()
Date: Tue, 4 Mar 2014 13:55:41 -0600 [thread overview]
Message-ID: <20140304195541.GB24463@saruman.home> (raw)
In-Reply-To: <xa1td2i14u63.fsf@mina86.com>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Tue, Mar 04, 2014 at 08:53:40PM +0100, Michal Nazarewicz wrote:
> >> On 03/04/2014 10:34 AM, Chuansheng Liu wrote:
> >> >@@ -845,12 +845,14 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data)
> >> > * we may end up with more data then user space has
> >> > * space for.
> >> > */
> >> >- ret = ep->status;
> >> >- if (io_data->read && ret > 0 &&
> >> >- unlikely(copy_to_user(io_data->buf, data,
> >> >- min_t(size_t, ret,
> >> >- io_data->len))))
> >> >- ret = -EFAULT;
> >> >+ ret = ep->status;
>
> On Tue, Mar 04 2014, Felipe Balbi wrote:
> >> Why the indentation jumped suddenly to the right?
>
> > On Tue, Mar 04, 2014 at 08:01:15PM +0300, Sergei Shtylyov wrote:
> > because it was wrong before ;-)
>
> Yep. It looks like Robert's [2e4c7553: add aio support] introduced an
> if-else-if-else flow but did not indent the code and I didn't caught it
> when reviewing that patch.
it's in my testing/next now, I also fixed the comment indentation which
was also wrong.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-03-04 19:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 7:34 Chuansheng Liu
2014-03-04 17:01 ` Sergei Shtylyov
2014-03-04 16:06 ` Felipe Balbi
2014-03-04 19:53 ` Michal Nazarewicz
2014-03-04 19:55 ` Felipe Balbi [this message]
2014-03-04 23:38 ` Liu, Chuansheng
2014-03-05 15:22 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304195541.GB24463@saruman.home \
--to=balbi@ti.com \
--cc=chuansheng.liu@intel.com \
--cc=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=r.baldyga@samsung.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®