Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile_io()

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

On Tue, Mar 04, 2014 at 11:38:32PM +0000, Liu, Chuansheng wrote:
> Hi Balbi,
> 
> > -----Original Message-----
> > From: Felipe Balbi [mailto:balbi@ti.com]
> > Sent: Wednesday, March 05, 2014 3:56 AM
> > To: Michal Nazarewicz
> > Cc: Robert Baldyga; Felipe Balbi; Sergei Shtylyov; Liu, Chuansheng;
> > gregkh@linuxfoundation.org; linux-usb@vger.kernel.org;
> > linux-kernel@vger.kernel.org; david.a.cohen@linux.intel.com
> > Subject: Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile_io()
> > 
> > On Tue, Mar 04, 2014 at 08:53:40PM +0100, Michal Nazarewicz wrote:
> > > >> On 03/04/2014 10:34 AM, Chuansheng Liu wrote:
> > > >> >@@ -845,12 +845,14 @@ static ssize_t ffs_epfile_io(struct file *file,
> > struct ffs_io_data *io_data)
> > > >> >  			 * we may end up with more data then user space has
> > > >> >  			 * space for.
> > > >> >  			 */
> > > >> >-			ret = ep->status;
> > > >> >-			if (io_data->read && ret > 0 &&
> > > >> >-			    unlikely(copy_to_user(io_data->buf, data,
> > > >> >-						  min_t(size_t, ret,
> > > >> >-						  io_data->len))))
> > > >> >-				ret = -EFAULT;
> > > >> >+				ret = ep->status;
> > >
> > > On Tue, Mar 04 2014, Felipe Balbi wrote:
> > > >>    Why the indentation jumped suddenly to the right?
> > >
> > > > On Tue, Mar 04, 2014 at 08:01:15PM +0300, Sergei Shtylyov wrote:
> > > > because it was wrong before ;-)
> > >
> > > Yep.  It looks like Robert's [2e4c7553: add aio support] introduced an
> > > if-else-if-else flow but did not indent the code and I didn't caught it
> > > when reviewing that patch.
> > 
> > it's in my testing/next now, I also fixed the comment indentation which
> > was also wrong.
> Thanks your help and the fix for comment indentation also:)

no problem, cheers ;-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]