mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Cooper <jason@lakedaemon.net>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	devicetree@vger.kernel.org, Tawfik Bayouk <tawfik@marvell.com>,
	linux-kernel@vger.kernel.org, Nadav Haklai <nadavh@marvell.com>,
	Lior Amsalem <alior@marvell.com>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board
Date: Fri, 7 Mar 2014 09:44:57 -0500	[thread overview]
Message-ID: <20140307144457.GC18707@titan.lakedaemon.net> (raw)
In-Reply-To: <53199726.4080300@free-electrons.com>

On Fri, Mar 07, 2014 at 10:53:42AM +0100, Gregory CLEMENT wrote:
> On 06/03/2014 20:17, Ezequiel Garcia wrote:
> > On Mar 06, Andrew Lunn wrote:
> >>> Can't we fix this so the probe order doesn't affect the name?
> >>>
> >>> Is that sane?
> >>
> >> You are not supposed to trust the device name, since probing can
> >> happen in parallel, on different buses. udev should have rules to name
> >> the interfaces based on the MAC address. On my Debian system i have:
> >>
> >> /etc/udev/rules.d/70-persistent-net.rules
> >>
> >> So what is important is that the MAC addresses are assigned correctly
> >> to the device. And DT does that based on MMIO address, so should be
> >> reliable, independent of probe order.

errr... I've always viewed the udev rules for persistent naming as a
hacky work-around.  If we have an opportunity to present consistent
names to userspace, then we should do that.  Otherwise, why would
devicetree have the ability to assign aliases?

> I was aware of this solution, and indeed for the end user it is the thing
> to do.

If we're broken, then yes.  Once we fix it, then the udev rules would
just confirm that the naming is the same from the previous boot.

thx,

Jason.

  reply	other threads:[~2014-03-07 14:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06 12:11 Gregory CLEMENT
2014-03-06 13:14 ` Andrew Lunn
2014-03-06 13:26   ` Gregory CLEMENT
2014-03-06 14:21     ` Andrew Lunn
2014-03-06 14:31       ` Gregory CLEMENT
2014-03-06 14:46         ` Andrew Lunn
2014-03-06 14:51           ` Gregory CLEMENT
2014-03-06 15:47             ` Gregory CLEMENT
2014-03-06 16:02               ` Ezequiel Garcia
2014-03-06 17:23                 ` Andrew Lunn
2014-03-06 19:17                   ` Ezequiel Garcia
2014-03-07  9:53                     ` Gregory CLEMENT
2014-03-07 14:44                       ` Jason Cooper [this message]
2014-03-07 21:42                   ` One Thousand Gnomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140307144457.GC18707@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadavh@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tawfik@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®