[GIT PULL] libata fixes for v3.14-rc5

[GIT PULL] libata fixes for v3.14-rc5

[Tejun Heo]

Hello, Linus.

Just a couple patches blacklisting more broken devices.

The following changes since commit 67809f85d31eac600f6b28defa5386c9d2a13b1d:

  ahci: disable NCQ on Samsung pci-e SSDs on macbooks (2014-02-18 10:22:17 -0500)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git for-3.14-fixes

for you to fetch changes up to b28a613e9138e4b3a64649bd60b13436f4b4b49b:

  libata: add ATA_HORKAGE_BROKEN_FPDMA_AA quirk for Seagate Momentus SpinPoint M8 (2BA30001) (2014-03-07 13:47:34 -0500)

Thanks.

----------------------------------------------------------------
Marios Andreopoulos (1):
      libata: disable queued TRIM for Crucial M500 mSATA SSDs

Michele Baldessari (1):
      libata: add ATA_HORKAGE_BROKEN_FPDMA_AA quirk for Seagate Momentus SpinPoint M8 (2BA30001)

 drivers/ata/libata-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 1a3dbd1..65d3f1b 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4175,6 +4175,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 
 	/* Seagate Momentus SpinPoint M8 seem to have FPMDA_AA issues */
 	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
+	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
 
 	/* Blacklist entries taken from Silicon Image 3124/3132
 	   Windows driver .inf file - also several Linux problem reports */
@@ -4225,6 +4226,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	/* devices that don't properly handle queued TRIM commands */
 	{ "Micron_M500*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
 	{ "Crucial_CT???M500SSD1",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Crucial_CT???M500SSD3",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
 
 	/*
 	 * Some WD SATA-I drives spin up and down erratically when the link

Re: [GIT PULL] libata fixes for v3.14-rc5

[Linus Torvalds]

On Sat, Mar 8, 2014 at 7:28 AM, Tejun Heo <tj@kernel.org> wrote:
>
> Just a couple patches blacklisting more broken devices.

Pulled. However:

>         /* devices that don't properly handle queued TRIM commands */
>         { "Micron_M500*",               NULL,   ATA_HORKAGE_NO_NCQ_TRIM, },
>         { "Crucial_CT???M500SSD1",      NULL,   ATA_HORKAGE_NO_NCQ_TRIM, },
> +       { "Crucial_CT???M500SSD3",      NULL,   ATA_HORKAGE_NO_NCQ_TRIM, },

If we know M500SSD1 and M500SSD3 are both broken the same way, and the
Micron_M500* is too (which is, as far as I know, the same device), why
the heck do we make the test that specific?

Why not just use Crucial_CT???M500* or something? The likelihood of
some new version of the same broken device coming up is small, and if
it does, we don't even care. Why would we risk it?

            Linus

[GIT PULL] libata fixes for v3.14-rc5

[Tejun Heo]

Hello, Linus.

Yeah, that makes sense.  I merged the two entries into
"Crucial_CT???M500SSD*".

The following changes since commit b28a613e9138e4b3a64649bd60b13436f4b4b49b:

  libata: add ATA_HORKAGE_BROKEN_FPDMA_AA quirk for Seagate Momentus SpinPoint M8 (2BA30001) (2014-03-07 13:47:34 -0500)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git for-3.14-fixes

for you to fetch changes up to 83493d7e782d2630f1a55def14a79f0e7c4faac3:

  libata: use wider match for blacklisting Crucial M500 (2014-03-10 11:17:55 -0400)

Thanks.

----------------------------------------------------------------
Tejun Heo (1):
      libata: use wider match for blacklisting Crucial M500

 drivers/ata/libata-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 65d3f1b..8cb2522 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4225,8 +4225,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 
 	/* devices that don't properly handle queued TRIM commands */
 	{ "Micron_M500*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
-	{ "Crucial_CT???M500SSD1",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
-	{ "Crucial_CT???M500SSD3",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Crucial_CT???M500SSD*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
 
 	/*
 	 * Some WD SATA-I drives spin up and down erratically when the link