From: Mark Rutland <mark.rutland@arm.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: "linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Chris Zankel <chris@zankel.net>, Marc Gauthier <marc@cadence.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 2/3] spi/xtensa-xtfpga: add DT binding documentation
Date: Wed, 12 Mar 2014 15:13:20 +0000 [thread overview]
Message-ID: <20140312151320.GB5035@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1394626865-15105-3-git-send-email-jcmvbkbc@gmail.com>
On Wed, Mar 12, 2014 at 12:21:04PM +0000, Max Filippov wrote:
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt b/Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt
> new file mode 100644
> index 0000000..b6ebe2b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt
> @@ -0,0 +1,9 @@
> +Cadence Xtensa XTFPGA platform SPI controller.
> +
> +This simple SPI master controller is built into xtfpga bitstreams and is used
> +to control daughterboard audio codec.
> +
> +Required properties:
> +- compatible: should be "cdns,xtfpga-spi".
Is that the official name of the block? Nothing more specific?
> +- reg: physical base address of the controller and length of memory mapped
> + region.
No interrupts?
Otherwise, this looks fine to me.
Cheers,
Mark.
next prev parent reply other threads:[~2014-03-12 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 12:21 [PATCH v2 0/3] xtensa xtfpga SPI controller driver Max Filippov
2014-03-12 12:21 ` [PATCH v2 1/3] spi: add " Max Filippov
2014-03-12 12:49 ` Mark Brown
2014-03-12 17:13 ` Max Filippov
2014-03-12 12:21 ` [PATCH v2 2/3] spi/xtensa-xtfpga: add DT binding documentation Max Filippov
2014-03-12 15:13 ` Mark Rutland [this message]
2014-03-12 17:21 ` Max Filippov
2014-03-12 12:21 ` [PATCH v2 3/3] MAINTAINERS: add xtfpga platform section Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312151320.GB5035@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=chris@zankel.net \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=marc@cadence.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®