From: Felipe Balbi <balbi@ti.com>
To: Suresh Gupta <suresh.gupta@freescale.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Suresh Gupta <B42813@freescale.com>
Subject: Re: [PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device
Date: Thu, 13 Mar 2014 10:27:27 -0500 [thread overview]
Message-ID: <20140313152727.GJ4599@saruman.home> (raw)
In-Reply-To: <1394719632-27101-1-git-send-email-suresh.gupta@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
Hi,
On Thu, Mar 13, 2014 at 07:37:12PM +0530, Suresh Gupta wrote:
> From: Suresh Gupta <B42813@freescale.com>
return -ENOLOG
> Signed-off-by: Suresh Gupta <B42813@freescale.com>
> ---
> drivers/usb/gadget/fsl_udc_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
> index 35b20e6..2a43d9d 100644
> --- a/drivers/usb/gadget/fsl_udc_core.c
> +++ b/drivers/usb/gadget/fsl_udc_core.c
> @@ -2456,6 +2456,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev)
> /* Setup gadget.dev and register with kernel */
> dev_set_name(&udc_controller->gadget.dev, "gadget");
> udc_controller->gadget.dev.of_node = pdev->dev.of_node;
> + set_dma_ops(&udc_controller->gadget.dev, pdev->dev.archdata.dma_ops);
why is the driver doing this ? Why is the driver given knowledge about
details on archdata ?
Why do you need this at all ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-03-13 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 14:07 Suresh Gupta
2014-03-13 15:27 ` Felipe Balbi [this message]
2014-03-14 20:53 ` suresh.gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313152727.GJ4599@saruman.home \
--to=balbi@ti.com \
--cc=B42813@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=suresh.gupta@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®