[PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device

[PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device

[Suresh Gupta]

From: Suresh Gupta <B42813@freescale.com>

Signed-off-by: Suresh Gupta <B42813@freescale.com>
---
 drivers/usb/gadget/fsl_udc_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
index 35b20e6..2a43d9d 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2456,6 +2456,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev)
 	/* Setup gadget.dev and register with kernel */
 	dev_set_name(&udc_controller->gadget.dev, "gadget");
 	udc_controller->gadget.dev.of_node = pdev->dev.of_node;
+	set_dma_ops(&udc_controller->gadget.dev, pdev->dev.archdata.dma_ops);
 
 	if (!IS_ERR_OR_NULL(udc_controller->transceiver))
 		udc_controller->gadget.is_otg = 1;
-- 
1.7.11.7

Re: [PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

Hi,

On Thu, Mar 13, 2014 at 07:37:12PM +0530, Suresh Gupta wrote:
> From: Suresh Gupta <B42813@freescale.com>

return -ENOLOG

> Signed-off-by: Suresh Gupta <B42813@freescale.com>
> ---
>  drivers/usb/gadget/fsl_udc_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
> index 35b20e6..2a43d9d 100644
> --- a/drivers/usb/gadget/fsl_udc_core.c
> +++ b/drivers/usb/gadget/fsl_udc_core.c
> @@ -2456,6 +2456,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev)
>  	/* Setup gadget.dev and register with kernel */
>  	dev_set_name(&udc_controller->gadget.dev, "gadget");
>  	udc_controller->gadget.dev.of_node = pdev->dev.of_node;
> +	set_dma_ops(&udc_controller->gadget.dev, pdev->dev.archdata.dma_ops);

why is the driver doing this ? Why is the driver given knowledge about
details on archdata ?

Why do you need this at all ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

RE: [PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device

[suresh.gupta]

Hi,

-----Original Message-----
From: Felipe Balbi [mailto:balbi@ti.com] 
Sent: Thursday, March 13, 2014 8:57 PM
To: Gupta Suresh-B42813
Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta Suresh-B42813
Subject: Re: [PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device

Hi,

On Thu, Mar 13, 2014 at 07:37:12PM +0530, Suresh Gupta wrote:
> From: Suresh Gupta <B42813@freescale.com>

return -ENOLOG

> Signed-off-by: Suresh Gupta <B42813@freescale.com>
> ---
>  drivers/usb/gadget/fsl_udc_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/fsl_udc_core.c 
> b/drivers/usb/gadget/fsl_udc_core.c
> index 35b20e6..2a43d9d 100644
> --- a/drivers/usb/gadget/fsl_udc_core.c
> +++ b/drivers/usb/gadget/fsl_udc_core.c
> @@ -2456,6 +2456,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev)
>  	/* Setup gadget.dev and register with kernel */
>  	dev_set_name(&udc_controller->gadget.dev, "gadget");
>  	udc_controller->gadget.dev.of_node = pdev->dev.of_node;
> +	set_dma_ops(&udc_controller->gadget.dev, 
> +pdev->dev.archdata.dma_ops);

why is the driver doing this ? Why is the driver given knowledge about details on archdata ?

Why do you need this at all ?
[SuresH] This is due to moving mapping virtual address functions 
to common "udc-core.c" where for example the dma_map_single expect dma_ops of gadget device. 
Before we call this function from our file with argument dma_map_single(ep->udc->gadget.dev.parent,.....

----
Thanks
SuresH