* [PATCH] Xen: include asm/page.h in xen-ops.h
@ 2014-03-15 9:42 Arnd Bergmann
2014-03-17 12:28 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2014-03-15 9:42 UTC (permalink / raw)
To: xen-devel
Cc: Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel,
linux-kernel, Stefano Stabellini
The declaration of xen_remap_domain_mfn_range relies on the
pgprot_t typedef to be visible. In some configurations, that
may not already have been seen, and I have encountered a
bug during randconfig testing on ARM.
Adding an explicit #include for asm/page.h fixes the problem.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index 6d8c042..b8ad234 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -3,6 +3,7 @@
#include <linux/percpu.h>
#include <asm/xen/interface.h>
+#include <asm/page.h>
DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Xen: include asm/page.h in xen-ops.h
2014-03-15 9:42 [PATCH] Xen: include asm/page.h in xen-ops.h Arnd Bergmann
@ 2014-03-17 12:28 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2014-03-17 12:28 UTC (permalink / raw)
To: Arnd Bergmann
Cc: xen-devel, Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel,
linux-kernel, Stefano Stabellini
On Sat, 15 Mar 2014, Arnd Bergmann wrote:
> The declaration of xen_remap_domain_mfn_range relies on the
> pgprot_t typedef to be visible. In some configurations, that
> may not already have been seen, and I have encountered a
> bug during randconfig testing on ARM.
>
> Adding an explicit #include for asm/page.h fixes the problem.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I'll add to xentip
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index 6d8c042..b8ad234 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -3,6 +3,7 @@
>
> #include <linux/percpu.h>
> #include <asm/xen/interface.h>
> +#include <asm/page.h>
>
> DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-17 12:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-15 9:42 [PATCH] Xen: include asm/page.h in xen-ops.h Arnd Bergmann
2014-03-17 12:28 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome