From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, sameo@linux.intel.com, lee.jones@linaro.org,
lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] regulator: arizona-ldo1: Move setup processing from arizona-core
Date: Tue, 18 Mar 2014 14:11:42 +0000 [thread overview]
Message-ID: <20140318141142.GC1665@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20140318111049.GJ11706@sirena.org.uk>
On Tue, Mar 18, 2014 at 11:10:49AM +0000, Mark Brown wrote:
> On Tue, Mar 18, 2014 at 10:49:12AM +0000, Charles Keepax wrote:
>
> > +#ifdef CONFIG_OF
> > +static int arizona_ldo1_get_pdata(struct arizona *arizona,
> > + struct regulator_config *config)
> > +{
> > + arizona_of_get_named_gpio(arizona, "wlf,ldoena", true,
> > + &config->ena_gpio);
> > +
> > + return 0;
> > +}
> > +#else
> > +static inline int arizona_ldo1_get_pdata(struct arizona *arizona,
> > + struct regulator_config *config)
> > +{
> > + struct arizona_pdata *pdata = &arizona->pdata;
> > +
> > + config->ena_gpio = arizona->pdata.ldoena;
>
> This breaks non-DT systems booting a kernel which has DT support
> compiled in. It's also more than simple code motion which is what the
> changelog claimed this was doing.
Oops.. sorry that is a good point I will respin these.
Thanks,
Charles
next prev parent reply other threads:[~2014-03-18 14:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 10:49 [PATCH 0/8] Arizona regulator updates Charles Keepax
2014-03-18 10:49 ` [PATCH 1/8] arizona: Correct small errors in the DT binding documentation Charles Keepax
2014-03-18 10:49 ` [PATCH 2/8] mfd: arizona: Factor out read of device tree GPIOs Charles Keepax
2014-03-18 10:49 ` [PATCH 3/8] regulator: arizona-ldo1: Move setup processing from arizona-core Charles Keepax
2014-03-18 11:10 ` Mark Brown
2014-03-18 14:11 ` Charles Keepax [this message]
2014-03-18 10:49 ` [PATCH 4/8] regulator: arizona-ldo1: Add processing of init_data from device tree Charles Keepax
2014-03-18 11:15 ` Mark Brown
2014-03-18 16:07 ` Charles Keepax
2014-03-18 16:19 ` Mark Brown
2014-03-18 10:49 ` [PATCH 5/8] regulator: arizona-micsupp: " Charles Keepax
2014-03-18 10:49 ` [PATCH 6/8] mfd: arizona: Add MICVDD to mapped regulators Charles Keepax
2014-03-18 10:49 ` [PATCH 7/8] mfd: wm8997: Add registers for high power mode Charles Keepax
2014-03-18 10:49 ` [PATCH 8/8] regulator: arizona-ldo1: Correct default regulator init_data Charles Keepax
2014-03-18 11:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318141142.GC1665@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome