* [PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name
@ 2014-03-04 5:46 Sachin Kamat
2014-03-04 5:46 ` [PATCH 2/2] regulator: s2mps11: Add missing of_node_put Sachin Kamat
2014-03-19 13:11 ` [PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2014-03-04 5:46 UTC (permalink / raw)
To: linux-kernel; +Cc: broonie, lgirdwood, sbkim73, sachin.kamat
of_find_node_by_name walks the allnodes list, and can thus walk
outside of the parent node. Use of_get_child_by_name instead.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/regulator/s2mps11.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
index b51ccf5..0f6177b 100644
--- a/drivers/regulator/s2mps11.c
+++ b/drivers/regulator/s2mps11.c
@@ -438,7 +438,7 @@ static int s2mps11_pmic_probe(struct platform_device *pdev)
for (i = 0; i < s2mps11->rdev_num; i++)
rdata[i].name = regulators[i].name;
- reg_np = of_find_node_by_name(iodev->dev->of_node, "regulators");
+ reg_np = of_get_child_by_name(iodev->dev->of_node, "regulators");
if (!reg_np) {
dev_err(&pdev->dev, "could not find regulators sub-node\n");
ret = -EINVAL;
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 2/2] regulator: s2mps11: Add missing of_node_put
2014-03-04 5:46 [PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name Sachin Kamat
@ 2014-03-04 5:46 ` Sachin Kamat
2014-03-19 13:11 ` Mark Brown
2014-03-19 13:11 ` [PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2014-03-04 5:46 UTC (permalink / raw)
To: linux-kernel; +Cc: broonie, lgirdwood, sbkim73, sachin.kamat
Add of_node_put to decrement the ref count.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/regulator/s2mps11.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
index 0f6177b..6eaf69b 100644
--- a/drivers/regulator/s2mps11.c
+++ b/drivers/regulator/s2mps11.c
@@ -446,6 +446,7 @@ static int s2mps11_pmic_probe(struct platform_device *pdev)
}
of_regulator_match(&pdev->dev, reg_np, rdata, s2mps11->rdev_num);
+ of_node_put(reg_np);
common_reg:
platform_set_drvdata(pdev, s2mps11);
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name
2014-03-04 5:46 [PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name Sachin Kamat
2014-03-04 5:46 ` [PATCH 2/2] regulator: s2mps11: Add missing of_node_put Sachin Kamat
@ 2014-03-19 13:11 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-03-19 13:11 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, lgirdwood, sbkim73
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
On Tue, Mar 04, 2014 at 11:16:57AM +0530, Sachin Kamat wrote:
> of_find_node_by_name walks the allnodes list, and can thus walk
> outside of the parent node. Use of_get_child_by_name instead.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-19 13:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-04 5:46 [PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name Sachin Kamat
2014-03-04 5:46 ` [PATCH 2/2] regulator: s2mps11: Add missing of_node_put Sachin Kamat
2014-03-19 13:11 ` Mark Brown
2014-03-19 13:11 ` [PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®